Skip to content

deps: Update golang.org/x/tools@v0.8.0#270

Merged
bflad merged 1 commit intomainfrom
bflad/x-text-update
Apr 13, 2023
Merged

deps: Update golang.org/x/tools@v0.8.0#270
bflad merged 1 commit intomainfrom
bflad/x-text-update

Conversation

@bflad
Copy link
Copy Markdown
Owner

@bflad bflad commented Apr 13, 2023

Closes #255
Reference: golang/go#56494

Manual upgrade due to prior Go panic:

$ go get golang.org/x/tools@v0.8.0
panic: internal error: can't find reason for requirement on golang.org/x/crypto@v0.0.0-20200622213623-75b288015ac9

goroutine 1 [running]:
cmd/go/internal/modget.(*resolver).updateBuildList.func1({{0x1400043ed80, 0x13}, {0x140000c2e70, 0x22}})
        /opt/homebrew/Cellar/go/1.20.3/libexec/src/cmd/go/internal/modget/get.go:1760 +0xc4
cmd/go/internal/modget.(*resolver).updateBuildList(0x1400007e000, {0x100f55398, 0x1400009e000}, {0x0, 0x0, 0x0})
        /opt/homebrew/Cellar/go/1.20.3/libexec/src/cmd/go/internal/modget/get.go:1765 +0x41c
cmd/go/internal/modget.(*resolver).resolveQueries(0x1400007e000, {0x100f55398, 0x1400009e000}, {0x140000b0090, 0x1, 0x10126bde0?})
        /opt/homebrew/Cellar/go/1.20.3/libexec/src/cmd/go/internal/modget/get.go:1243 +0x148
cmd/go/internal/modget.runGet({0x100f55398, 0x1400009e000}, 0x140000b8600?, {0x1400009a1a0, 0x1, 0x1})
        /opt/homebrew/Cellar/go/1.20.3/libexec/src/cmd/go/internal/modget/get.go:314 +0x38c
main.invoke(0x10125e3c0, {0x1400009a190, 0x2, 0x2})
        /opt/homebrew/Cellar/go/1.20.3/libexec/src/cmd/go/main.go:225 +0x37c
main.main()
        /opt/homebrew/Cellar/go/1.20.3/libexec/src/cmd/go/main.go:179 +0x7cc

Updated via:

go get golang.org/x/crypto@latest # panic workaround
go get golang.org/x/tools@v0.8.0
go mod tidy
go mod vendor

Introduces xpasses/XR007 and xpasses/XR008 test skips due to golang.org/x/tools now properly returning an error with invalid source files. This is expected with the suggested fixes implementation since those will intentionally remove source code, leaving the source code in an unbuildable state to encourage the developer to figure out the rest of the necessary solution.

Reference: #255
Reference: golang/go#56494

Manual upgrade due to prior Go panic:

```console
$ go get golang.org/x/tools@v0.8.0
panic: internal error: can't find reason for requirement on golang.org/x/crypto@v0.0.0-20200622213623-75b288015ac9

goroutine 1 [running]:
cmd/go/internal/modget.(*resolver).updateBuildList.func1({{0x1400043ed80, 0x13}, {0x140000c2e70, 0x22}})
        /opt/homebrew/Cellar/go/1.20.3/libexec/src/cmd/go/internal/modget/get.go:1760 +0xc4
cmd/go/internal/modget.(*resolver).updateBuildList(0x1400007e000, {0x100f55398, 0x1400009e000}, {0x0, 0x0, 0x0})
        /opt/homebrew/Cellar/go/1.20.3/libexec/src/cmd/go/internal/modget/get.go:1765 +0x41c
cmd/go/internal/modget.(*resolver).resolveQueries(0x1400007e000, {0x100f55398, 0x1400009e000}, {0x140000b0090, 0x1, 0x10126bde0?})
        /opt/homebrew/Cellar/go/1.20.3/libexec/src/cmd/go/internal/modget/get.go:1243 +0x148
cmd/go/internal/modget.runGet({0x100f55398, 0x1400009e000}, 0x140000b8600?, {0x1400009a1a0, 0x1, 0x1})
        /opt/homebrew/Cellar/go/1.20.3/libexec/src/cmd/go/internal/modget/get.go:314 +0x38c
main.invoke(0x10125e3c0, {0x1400009a190, 0x2, 0x2})
        /opt/homebrew/Cellar/go/1.20.3/libexec/src/cmd/go/main.go:225 +0x37c
main.main()
        /opt/homebrew/Cellar/go/1.20.3/libexec/src/cmd/go/main.go:179 +0x7cc
```

Updated via:

```shell
go get golang.org/x/crypto@latest # panic workaround
go get golang.org/x/tools@v0.8.0
go mod tidy
go mod vendor
```

Introduces `xpasses/XR007` and `xpasses/XR008` test skips due to `golang.org/x/tools` now properly returning an error with invalid source files. This is expected with the suggested fixes implementation since those will intentionally remove source code, leaving the source code in an unbuildable state to encourage the developer to figure out the rest of the necessary solution.
@bflad bflad added dependencies Pull requests that update a dependency file go Pull requests that update Go code labels Apr 13, 2023
@bflad bflad added this to the v0.29.0 milestone Apr 13, 2023
@bflad bflad merged commit 7b14c94 into main Apr 13, 2023
@bflad bflad deleted the bflad/x-text-update branch April 13, 2023 18:26
bflad added a commit that referenced this pull request Apr 13, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

dependencies Pull requests that update a dependency file go Pull requests that update Go code

Projects

None yet

Development

Successfully merging this pull request may close these issues.

internal error: package "context" without types was imported

1 participant