Skip to content

naga 0.14#63

Merged
robtfm merged 5 commits intobevyengine:masterfrom
robtfm:naga-0.14
Nov 17, 2023
Merged

naga 0.14#63
robtfm merged 5 commits intobevyengine:masterfrom
robtfm:naga-0.14

Conversation

@robtfm
Copy link
Copy Markdown
Collaborator

@robtfm robtfm commented Oct 25, 2023

update to naga 0.14

@torokati44
Copy link
Copy Markdown

With gfx-rs/wgpu#4569 merged, I think this should be unblocked now.

@robtfm
Copy link
Copy Markdown
Collaborator Author

robtfm commented Nov 11, 2023

i'll update once it's backported to 0.14.x and released, last i heard that will be this weekend

@torokati44
Copy link
Copy Markdown

Welp, no release happened last weekend.
But since then, a backport of that fix was merged: gfx-rs/wgpu#4693

@torokati44
Copy link
Copy Markdown

Aand wgpu 0.18.1 is out! 😊

@robtfm robtfm merged commit 1447b43 into bevyengine:master Nov 17, 2023
github-merge-queue bot pushed a commit to bevyengine/bevy that referenced this pull request Dec 14, 2023
# Objective

Keep up to date with wgpu.

## Solution

Update the wgpu version.

Currently blocked on naga_oil updating to naga 0.14 and releasing a new
version.

3d scenes (or maybe any scene with lighting?) currently don't render
anything due to
```
error: naga_oil bug, please file a report: composer failed to build a valid header: Type [2] '' is invalid
 = Capability Capabilities(CUBE_ARRAY_TEXTURES) is required
 ```

I'm not sure what should be passed in for `wgpu::InstanceFlags`, or if we want to make the gles3minorversion configurable (might be useful for debugging?)

Currently blocked on bevyengine/naga_oil#63, and gfx-rs/wgpu#4569 to be fixed upstream in wgpu first.

## Known issues

Amd+windows+vulkan has issues with texture_binding_arrays (see the image [here](#10266 (comment))), but that'll be fixed in the next wgpu/naga version, and you can just use dx12 as a workaround for now (Amd+linux mesa+vulkan texture_binding_arrays are fixed though).

---

## Changelog

Updated wgpu to 0.18, naga to 0.14.2, and naga_oil to 0.11.
- Windows desktop GL should now be less painful as it no longer requires Angle.
- You can now toggle shader validation and debug information for debug and release builds using `WgpuSettings.instance_flags` and [InstanceFlags](https://docs.rs/wgpu/0.18.0/wgpu/struct.InstanceFlags.html)

## Migration Guide

- `RenderPassDescriptor` `color_attachments`  (as well as `RenderPassColorAttachment`, and `RenderPassDepthStencilAttachment`) now use `StoreOp::Store` or `StoreOp::Discard` instead of a `boolean` to declare whether or not they should be stored.
- `RenderPassDescriptor` now have `timestamp_writes` and `occlusion_query_set` fields. These can safely be set to `None`.
- `ComputePassDescriptor` now have a `timestamp_writes` field. This can be set to `None` for now.
- See the [wgpu changelog](https://github.com/gfx-rs/wgpu/blob/trunk/CHANGELOG.md#v0180-2023-10-25) for additional details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

No open projects
Status: Done

Development

Successfully merging this pull request may close these issues.

3 participants