[Merged by Bors] - Add Examples to nav and add "intro" text#392
Closed
cart wants to merge 1 commit intobevyengine:masterfrom
Closed
[Merged by Bors] - Add Examples to nav and add "intro" text#392cart wants to merge 1 commit intobevyengine:masterfrom
cart wants to merge 1 commit intobevyengine:masterfrom
Conversation
IceSentry
approved these changes
Jul 8, 2022
Contributor
IceSentry
left a comment
There was a problem hiding this comment.
Not sure if we want to keep it in the learn section if it's already in the header, but other than that I tried it locally and it looks good.
Member
|
I'm on board with this choice :) |
mockersf
approved these changes
Jul 8, 2022
Member
Author
|
bors r+ |
Member
Author
I think we probably do as we don't want people to accidentally miss the examples when looking for learning material. |
bors bot
pushed a commit
that referenced
this pull request
Jul 8, 2022
I think we've ironed out enough of the kinks to justify making the examples page more prominent. We've been sitting on a lot of value here for awhile 😄 For posterity: big thanks to @mockersf for putting together this feature in #225 and @doup for adding loading feedback in #355 and a bunch of other visual improvements.
|
Pull request successfully merged into master. Build succeeded: |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I think we've ironed out enough of the kinks to justify making the examples page more prominent. We've been sitting on a lot of value here for awhile 😄
For posterity: big thanks to @mockersf for putting together this feature in #225 and @doup for adding loading feedback in #355 and a bunch of other visual improvements.