Skip to content

[Merged by Bors] - Enable anchors on links in learn section#275

Closed
mockersf wants to merge 1 commit intobevyengine:masterfrom
mockersf:learn-anchors
Closed

[Merged by Bors] - Enable anchors on links in learn section#275
mockersf wants to merge 1 commit intobevyengine:masterfrom
mockersf:learn-anchors

Conversation

@mockersf
Copy link
Copy Markdown
Member

@mockersf mockersf commented Jan 18, 2022

Fixes #274

@alice-i-cecile
Copy link
Copy Markdown
Member

alice-i-cecile commented Jan 18, 2022

Ooh nice.

IceSentry
IceSentry approved these changes Jan 18, 2022
View reviewed changes
Copy link
Copy Markdown
Contributor

@IceSentry IceSentry left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Well, that was a fast turn around between creating an issue and having a solution.

@ghost ghost mentioned this pull request Feb 12, 2022
Closed
@alice-i-cecile
Copy link
Copy Markdown
Member

alice-i-cecile commented Mar 10, 2022

bors r+

bors bot pushed a commit that referenced this pull request Mar 10, 2022
@mockersf
Enable anchors on links in learn section (#275)
0832cf8 
Fixes #274
@alice-i-cecile alice-i-cecile added the S-Ready-For-Final-Review Ready for a maintainer to consider for merging label Mar 10, 2022
@bors
Copy link
Copy Markdown

bors bot commented Mar 10, 2022

Timed out.

bors bot pushed a commit that referenced this pull request Mar 10, 2022
Enable anchor links in book section (#280)
12f8425 
Enabled the anchor links in every `_index.md` file inside of the `content/learn/book` section.
I ported the changes made in #275 over to the `new_book` branch.

Closes #274 
Closes #275
@cart
Copy link
Copy Markdown
Member

cart commented Mar 10, 2022

bors r+

@mockersf
Copy link
Copy Markdown
Member Author

mockersf commented Mar 10, 2022

bors setup is not correct and will timeout, see #285

@mockersf
Copy link
Copy Markdown
Member Author

mockersf commented Mar 10, 2022

bors cancel

@bors
Copy link
Copy Markdown

bors bot commented Mar 10, 2022

Canceled.

@mockersf
Copy link
Copy Markdown
Member Author

mockersf commented Mar 11, 2022

bors r+

bors bot pushed a commit that referenced this pull request Mar 11, 2022
@mockersf
Enable anchors on links in learn section (#275)
7c13a44 
Fixes #274
@mockersf
Copy link
Copy Markdown
Member Author

mockersf commented Mar 11, 2022

(not sure bors will be happy here or if it need a rebase)

@bors
Copy link
Copy Markdown

bors bot commented Mar 11, 2022

Pull request successfully merged into master.

Build succeeded:

@bors bors bot changed the title Enable anchors on links in learn section [Merged by Bors] - Enable anchors on links in learn section Mar 11, 2022
@bors bors bot closed this Mar 11, 2022
bors bot pushed a commit that referenced this pull request Mar 11, 2022
Enable anchor links in book section (#280)
3b49f1b 
Enabled the anchor links in every `_index.md` file inside of the `content/learn/book` section.
I ported the changes made in #275 over to the `new_book` branch.

Closes #274 
Closes #275
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@alice-i-cecile alice-i-cecile alice-i-cecile approved these changes

+2 more reviewers

@rparrett rparrett rparrett approved these changes

@IceSentry IceSentry IceSentry approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

S-Ready-For-Final-Review Ready for a maintainer to consider for merging

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Turn section header into links

5 participants

@mockersf @alice-i-cecile @cart @rparrett @IceSentry