Replace `IntoSystemSetConfig` with `IntoSystemSetConfigs` by geieredgar · Pull Request #9247 · bevyengine/bevy

geieredgar · 2023-07-23T01:56:39Z

Objective

Fixes Deprecate configure_set & make configure_sets work for single params. #9244.

Solution

Changed the (Into)SystemSetConfigs traits and structs be more like the (Into)SystemConfigs traits and structs.
Replaced uses of IntoSystemSetConfig with IntoSystemSetConfigs
Added generic ItemConfig and ItemConfigs types.
Changed SystemConfig(s) and SystemSetConfig(s) to be type aliases to ItemConfig(s).
Added generic process_configs to ScheduleGraph.
Changed configure_sets_inner and add_systems_inner to reuse process_configs.

Changelog

Added run_if to IntoSystemSetConfigs
Deprecated Schedule::configure_set and App::configure_set
Removed IntoSystemSetConfig

Migration Guide

Use App::configure_sets instead of App::configure_set
Use Schedule::configure_sets instead of Schedule::configure_set

github-actions · 2023-07-23T02:01:43Z

Example alien_cake_addict failed to run, please try running it locally and check the result.

crates/bevy_ecs/src/schedule/schedule.rs

github-actions · 2023-08-14T08:34:45Z

Example alien_cake_addict failed to run, please try running it locally and check the result.

crates/bevy_ecs/src/schedule/schedule.rs

alice-i-cecile

I really like the refactor; this is way cleaner and easier to review. I think we can make the doc strings nicer, but as long as you explicitly work in the concept of "chaining == system ordering" I'll be happy to approve.

github-actions · 2023-08-14T13:23:35Z

Example alien_cake_addict failed to run, please try running it locally and check the result.

github-actions · 2023-08-14T13:23:40Z

Example alien_cake_addict failed to run, please try running it locally and check the result.

github-actions · 2023-08-14T13:24:28Z

Example alien_cake_addict failed to run, please try running it locally and check the result.

github-actions · 2023-08-14T13:30:06Z

Example alien_cake_addict failed to run, please try running it locally and check the result.

github-actions · 2023-08-14T13:42:38Z

Example alien_cake_addict failed to run, please try running it locally and check the result.

…ams.

Co-authored-by: Alice Cecile <alice.i.cecile@gmail.com>

crates/bevy_ecs/src/schedule/config.rs

crates/bevy_ecs/src/schedule/schedule.rs

…#9247) # Objective - Fixes bevyengine#9244. ## Solution - Changed the `(Into)SystemSetConfigs` traits and structs be more like the `(Into)SystemConfigs` traits and structs. - Replaced uses of `IntoSystemSetConfig` with `IntoSystemSetConfigs` - Added generic `ItemConfig` and `ItemConfigs` types. - Changed `SystemConfig(s)` and `SystemSetConfig(s)` to be type aliases to `ItemConfig(s)`. - Added generic `process_configs` to `ScheduleGraph`. - Changed `configure_sets_inner` and `add_systems_inner` to reuse `process_configs`. --- ## Changelog - Added `run_if` to `IntoSystemSetConfigs` - Deprecated `Schedule::configure_set` and `App::configure_set` - Removed `IntoSystemSetConfig` ## Migration Guide - Use `App::configure_sets` instead of `App::configure_set` - Use `Schedule::configure_sets` instead of `Schedule::configure_set` --------- Co-authored-by: Alice Cecile <alice.i.cecile@gmail.com>

geieredgar force-pushed the configure-sets branch 4 times, most recently from 2ad6fc9 to 1ed6a01 Compare July 23, 2023 11:54

mockersf added the A-ECS Entities, components, systems, and events label Jul 23, 2023

joseph-gio self-requested a review July 26, 2023 19:48

alice-i-cecile added this to the 0.12 milestone Aug 10, 2023

alice-i-cecile reviewed Aug 10, 2023

View reviewed changes