[Merged by Bors] - Cherry pick "bevy_reflect: Register missing reflected types for bevy_render (#6725)"#6811
Closed
cart wants to merge 1 commit intobevyengine:release-0.9.1from
Closed
[Merged by Bors] - Cherry pick "bevy_reflect: Register missing reflected types for bevy_render (#6725)"#6811cart wants to merge 1 commit intobevyengine:release-0.9.1from
bevy_render (#6725)"#6811cart wants to merge 1 commit intobevyengine:release-0.9.1from
Conversation
…yengine#6725) Many types in `bevy_render` implemented `Reflect` but were not registered. Register all types in `bevy_render` that impl `Reflect`. This also registers additional dependent types (i.e. field types). > Note: Adding these dependent types would not be needed using something like bevyengine#5781 😉 --- - Register missing `bevy_render` types in the `TypeRegistry`: - `camera::RenderTarget` - `globals::GlobalsUniform` - `texture::Image` - `view::ComputedVisibility` - `view::Visibility` - `view::VisibleEntities` - Register additional dependent types: - `view::ComputedVisibilityFlags` - `Vec<Entity>`
Member
Author
|
Lets see if this merges as-is or if we need to cherry pick the CI fixes :) |
Member
Author
|
bors r+ |
tim-blackbird
approved these changes
Dec 1, 2022
Contributor
|
FYI you shouldn't need the miri one as it hasn't been a part of r+'s for awhile |
Contributor
|
Build failed: |
Member
Author
|
Should be fixed now after cherry picking the relevant CI fixes into the 0.9.1 branch. |
Member
Author
|
bors r+ |
Contributor
bevy_render (#6725)"bevy_render (#6725)"
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This had merge conflicts with the 0.9.1 release branch, so this had to be merged manually. Creating a PR for visibility + a final review.