Skip to content

Add storage buffers limit check for gpu occlusion#23483

Merged
alice-i-cecile merged 1 commit intobevyengine:mainfrom
atlv24:ad/gpu-occlusion-gate
Mar 23, 2026
Merged

Add storage buffers limit check for gpu occlusion#23483
alice-i-cecile merged 1 commit intobevyengine:mainfrom
atlv24:ad/gpu-occlusion-gate

Conversation

@atlv24
Copy link
Copy Markdown
Contributor

@atlv24 atlv24 commented Mar 23, 2026

Objective

  • unblock wgpu 29 upgrade

Solution

  • check relevant limits to enable occlusion culling

Testing

patched this over the wgpu 29 upgrade branch and it no longer errors

@atlv24 atlv24 added A-Rendering Drawing game state to the screen S-Needs-Review Needs reviewer attention (from anyone!) to move forward labels Mar 23, 2026
@github-project-automation github-project-automation bot moved this to Needs SME Triage in Rendering Mar 23, 2026
@kfc35 kfc35 added this to the 0.19 milestone Mar 23, 2026
@ChristopherBiscardi ChristopherBiscardi added S-Ready-For-Final-Review This PR has been approved by the community. It's ready for a maintainer to consider merging it and removed S-Needs-Review Needs reviewer attention (from anyone!) to move forward labels Mar 23, 2026
@ChristopherBiscardi ChristopherBiscardi mentioned this pull request Mar 23, 2026
1 task
Copy link
Copy Markdown
Contributor

@kfc35 kfc35 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested on a Mac on top of the wgpu branch as well and it works correctly

“Occlusion culling not supported on this platform"

@alice-i-cecile alice-i-cecile added this pull request to the merge queue Mar 23, 2026
Merged via the queue into bevyengine:main with commit 8841e1c Mar 23, 2026
45 checks passed
@github-project-automation github-project-automation bot moved this from Needs SME Triage to Done in Rendering Mar 23, 2026
cartercanedy pushed a commit to joseph-gio/bevy that referenced this pull request Mar 26, 2026
# Objective

- unblock wgpu 29 upgrade

## Solution

- check relevant limits to enable occlusion culling

## Testing

patched this over the wgpu 29 upgrade branch and it no longer errors
cartercanedy added a commit to joseph-gio/bevy that referenced this pull request Mar 26, 2026
…age-buffer-count-check

Add storage buffers limit check for gpu occlusion (bevyengine#23483)
splo pushed a commit to splo/bevy that referenced this pull request Mar 31, 2026
# Objective

- unblock wgpu 29 upgrade

## Solution

- check relevant limits to enable occlusion culling

## Testing

patched this over the wgpu 29 upgrade branch and it no longer errors
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

A-Rendering Drawing game state to the screen S-Ready-For-Final-Review This PR has been approved by the community. It's ready for a maintainer to consider merging it

Projects

Status: Done

Development

Successfully merging this pull request may close these issues.

5 participants