Extraction Example #23223
Conversation
ChristopherBiscardi
left a comment
There was a problem hiding this comment.
Good first step for an extraction example. The most important changes I mentioned are the Example naming/category ones so that this isn't named "Custom Schedule" by accident. The other changes are ones I think would be good but reasonable people could disagree.
ChristopherBiscardi
left a comment
There was a problem hiding this comment.
A solid first land for documenting extraction! Now we have somewhere to point people to that they can run to look at what is actually happening, especially relating to "are they on the same entities", "when do the value update", etc.
Co-authored-by: Chris Biscardi <chris@christopherbiscardi.com>
Cargo.toml
Outdated
|
|
||
| [package.metadata.example.extraction] | ||
| name = "Extraction" | ||
| description = "Demonstrates different ways to extract components" |
There was a problem hiding this comment.
This example description is unhelpful: you need to explain what "extracting components" means to people who have never heard of it.
examples/ecs/extraction.rs
Outdated
| @@ -0,0 +1,125 @@ | |||
| //! Demonstrates different ways to extract components to another world. | |||
There was a problem hiding this comment.
These introductory needs additional context on why you might want to do this. Focusing on the rendering use case is fine.
alice-i-cecile
left a comment
There was a problem hiding this comment.
Content looks good, but it needs some work around framing to make this clear to intermediate users.
alice-i-cecile
left a comment
There was a problem hiding this comment.
Descriptions are much improved, thanks!
Might make more sense in a rendering-related example folder, but that's non-blocking.
I believe the intent here is accommodating for recent work like #22852 which means extraction is not rendering-only as a feature, even if that's where it is most often used at the moment. |
An example demonstrating automatic and manual extraction of components from the Main World to the Render World. This is a common point of confusion for new users that want to do custom rendering, and I don't think any of the current examples show how to manually extract components (or aren't at all focused on it at least). In the future this should probably be changed to be about extraction between two arbitrary worlds, instead of being specific to the Render World. Possibly after / if github.com/bevyengine/pull/22852 is merged. --------- Co-authored-by: Chris Biscardi <chris@christopherbiscardi.com>
An example demonstrating automatic and manual extraction of components from the Main World to the Render World.
This is a common point of confusion for new users that want to do custom rendering, and I don't think any of the current examples show how to manually extract components (or aren't at all focused on it at least).
In the future this should probably be changed to be about extraction between two arbitrary worlds, instead of being specific to the Render World. Possibly after / if github.com//pull/22852 is merged.