VertexAttributeValues supports all wgpu VertexFormat#22796
Merged
alice-i-cecile merged 8 commits intobevyengine:mainfrom Mar 16, 2026
Merged
Conversation
…lues-match-wgpu-vertex-format
VertexAttributeValues supports more VertexFormatVertexAttributeValues supports all wgpu VertexFormat
mockersf
approved these changes
Mar 14, 2026
kfc35
approved these changes
Mar 15, 2026
6 tasks
splo
pushed a commit
to splo/bevy
that referenced
this pull request
Mar 31, 2026
…22796) # Objective Some wgpu `VertexFormat`s are not supported by `VertexAttributeValues`. ## Solution Add them to `VertexAttributeValues`. Float64 is not supported by any wgpu backends but I added them anyway because wgpu has them. ~May require bevyengine#22187 to be fixed because for vertex formats less than 32 bits the `MeshBufferSlice::range` is incorrect. But generally vertex attributes are not affected by that issue if indices isn't u16.~ Note that wgpu requires vertex strides to be [4 bytes aligned](https://docs.rs/wgpu/latest/wgpu/constant.VERTEX_ALIGNMENT.html). Some vertex attribute is smaller than 4 bytes. It is user's responsibility to make sure the strides of custom vertex attributes is a multiple of 4. ## Testing None
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Objective
Some wgpu
VertexFormats are not supported byVertexAttributeValues.Solution
Add them to
VertexAttributeValues.Float64 is not supported by any wgpu backends but I added them anyway because wgpu has them.
May require #22187 to be fixed because for vertex formats less than 32 bits theMeshBufferSlice::rangeis incorrect. But generally vertex attributes are not affected by that issue if indices isn't u16.Note that wgpu requires vertex strides to be 4 bytes aligned. Some vertex attribute is smaller than 4 bytes. It is user's responsibility to make sure the strides of custom vertex attributes is a multiple of 4.
Testing
None