Skip to content

Add no_std support to bevy_diagnostic#17507

Merged
alice-i-cecile merged 2 commits intobevyengine:mainfrom
bushrat011899:NoSTDBevyDiagnostic
Jan 23, 2025
Merged

Add no_std support to bevy_diagnostic#17507
alice-i-cecile merged 2 commits intobevyengine:mainfrom
bushrat011899:NoSTDBevyDiagnostic

Conversation

@bushrat011899
Copy link
Copy Markdown
Contributor

@bushrat011899 bushrat011899 commented Jan 23, 2025

Objective

Solution

  • Added required features
  • Switched from tracing to log
  • Fixed imports

Testing

  • CI

@bushrat011899 bushrat011899 added C-Feature A new feature, making something new possible D-Trivial Nice and easy! A great choice to get started with Bevy A-Diagnostics Logging, crash handling, error reporting and performance analysis X-Uncontroversial This work is generally agreed upon S-Needs-Review Needs reviewer attention (from anyone!) to move forward O-Embedded Weird hardware and no_std platforms labels Jan 23, 2025
@bushrat011899 bushrat011899 mentioned this pull request Jan 23, 2025
Closed
@alice-i-cecile alice-i-cecile added S-Ready-For-Final-Review This PR has been approved by the community. It's ready for a maintainer to consider merging it and removed S-Needs-Review Needs reviewer attention (from anyone!) to move forward labels Jan 23, 2025
@alice-i-cecile alice-i-cecile added this pull request to the merge queue Jan 23, 2025
Merged via the queue into bevyengine:main with commit 8e6bf06 Jan 23, 2025
mrchantey pushed a commit to mrchantey/bevy that referenced this pull request Feb 4, 2025
@bushrat011899 @mrchantey
Add no_std support to bevy_diagnostic (bevyengine#17507)
0928ec9 
# Objective

- Contributes to bevyengine#15460

## Solution

- Added required features
- Switched from `tracing` to `log`
- Fixed imports

## Testing

- CI
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@alice-i-cecile alice-i-cecile alice-i-cecile approved these changes

Assignees

No one assigned

Labels

A-Diagnostics Logging, crash handling, error reporting and performance analysis C-Feature A new feature, making something new possible D-Trivial Nice and easy! A great choice to get started with Bevy O-Embedded Weird hardware and no_std platforms S-Ready-For-Final-Review This PR has been approved by the community. It's ready for a maintainer to consider merging it X-Uncontroversial This work is generally agreed upon

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@bushrat011899 @alice-i-cecile