Skip to content

no_std Support for bevy_input_focus#17490

Merged
alice-i-cecile merged 3 commits intobevyengine:mainfrom
bushrat011899:NoSTDBevyInputFocus
Jan 22, 2025
Merged

no_std Support for bevy_input_focus#17490
alice-i-cecile merged 3 commits intobevyengine:mainfrom
bushrat011899:NoSTDBevyInputFocus

Conversation

@bushrat011899
Copy link
Copy Markdown
Contributor

@bushrat011899 bushrat011899 commented Jan 22, 2025

Objective

Solution

  • Switched tracing for log for the atomically challenged platforms
  • Setup feature flags as required
  • Added to compile-check-no-std CI task

Testing

  • CI

Notes

  • Very easy one this time. Most of the changes here are just feature definitions and documentation within the Cargo.toml

@bushrat011899 bushrat011899 added C-Feature A new feature, making something new possible D-Trivial Nice and easy! A great choice to get started with Bevy A-Input Player input via keyboard, mouse, gamepad, and more X-Uncontroversial This work is generally agreed upon S-Needs-Review Needs reviewer attention (from anyone!) to move forward O-Embedded Weird hardware and no_std platforms labels Jan 22, 2025
@bushrat011899 bushrat011899 mentioned this pull request Jan 22, 2025
Closed
TimJentzsch
TimJentzsch approved these changes Jan 22, 2025
View reviewed changes
Copy link
Copy Markdown
Contributor

@TimJentzsch TimJentzsch left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Are there any negative effects when part of the crates use tracing and others log, e.g. harder to configure the log messages?

If yes, perhaps we can make it feature dependent in some way. Wouldnt have to happen in this PR though.

@TimJentzsch TimJentzsch added S-Ready-For-Final-Review This PR has been approved by the community. It's ready for a maintainer to consider merging it and removed S-Needs-Review Needs reviewer attention (from anyone!) to move forward labels Jan 22, 2025
@bushrat011899
Copy link
Copy Markdown
Contributor Author

bushrat011899 commented Jan 22, 2025

Are there any negative effects when part of the crates use tracing and others log, e.g. harder to configure the log messages?

It should be quite seamless. Tokio provides tracing-log as an official integration for log with tracing that'll capture everything with very little setup (Bevy includes this by default in bevy_log already too). The main thing we miss out on is the span functionality that tracing provides. However, if you're only using the logging macros like tracing::info, they should be identical to log::info, etc.

@alice-i-cecile alice-i-cecile added this pull request to the merge queue Jan 22, 2025
Merged via the queue into bevyengine:main with commit 5c43890 Jan 22, 2025
mrchantey pushed a commit to mrchantey/bevy that referenced this pull request Feb 4, 2025
@bushrat011899 @mrchantey
no_std Support for bevy_input_focus (bevyengine#17490)
ac5d8bd 
# Objective

- Contributes to bevyengine#15460

## Solution

- Switched `tracing` for `log` for the atomically challenged platforms
- Setup feature flags as required
- Added to `compile-check-no-std` CI task

## Testing

- CI

---

## Notes

- _Very_ easy one this time. Most of the changes here are just feature
definitions and documentation within the `Cargo.toml`
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

2 more reviewers

@TimJentzsch TimJentzsch TimJentzsch approved these changes

@BenjaminBrienen BenjaminBrienen BenjaminBrienen approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

A-Input Player input via keyboard, mouse, gamepad, and more C-Feature A new feature, making something new possible D-Trivial Nice and easy! A great choice to get started with Bevy O-Embedded Weird hardware and no_std platforms S-Ready-For-Final-Review This PR has been approved by the community. It's ready for a maintainer to consider merging it X-Uncontroversial This work is generally agreed upon

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@bushrat011899 @TimJentzsch @BenjaminBrienen @alice-i-cecile