Skip to content

Remove bevy_core_pipeline::core_2d::Camera2dBundle#17185

Merged
alice-i-cecile merged 2 commits intobevyengine:mainfrom
LikeLakers2:bevy_core_pipeline/remove_camera2dbundle
Jan 6, 2025
Merged

Remove bevy_core_pipeline::core_2d::Camera2dBundle#17185
alice-i-cecile merged 2 commits intobevyengine:mainfrom
LikeLakers2:bevy_core_pipeline/remove_camera2dbundle

Conversation

@LikeLakers2
Copy link
Contributor

Objective

#16338 forgot to remove this previously-deprecated item. In fact, it only removed the #[deprecated] attribute attached to it.

Solution

Removes bevy_core_pipeline::core_2d::Camera2dBundle.

Testing

CI.

@alice-i-cecile alice-i-cecile added this to the 0.16 milestone Jan 6, 2025
@TimJentzsch TimJentzsch added D-Trivial Nice and easy! A great choice to get started with Bevy A-Rendering Drawing game state to the screen C-Code-Quality A section of code that is hard to understand or change S-Needs-Review Needs reviewer attention (from anyone!) to move forward labels Jan 6, 2025
Copy link
Contributor

@rparrett rparrett left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. Couldn't find any other stragglers.

@BenjaminBrienen BenjaminBrienen added S-Ready-For-Final-Review This PR has been approved by the community. It's ready for a maintainer to consider merging it and removed S-Needs-Review Needs reviewer attention (from anyone!) to move forward labels Jan 6, 2025
@alice-i-cecile alice-i-cecile added this pull request to the merge queue Jan 6, 2025
Merged via the queue into bevyengine:main with commit 51075aa Jan 6, 2025
@LikeLakers2 LikeLakers2 deleted the bevy_core_pipeline/remove_camera2dbundle branch January 6, 2025 19:55
mrchantey pushed a commit to mrchantey/bevy that referenced this pull request Feb 4, 2025
# Objective
bevyengine#16338 forgot to remove this
previously-deprecated item. In fact, it only removed the `#[deprecated]`
attribute attached to it.

## Solution
Removes `bevy_core_pipeline::core_2d::Camera2dBundle`.

## Testing
CI.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

A-Rendering Drawing game state to the screen C-Code-Quality A section of code that is hard to understand or change D-Trivial Nice and easy! A great choice to get started with Bevy S-Ready-For-Final-Review This PR has been approved by the community. It's ready for a maintainer to consider merging it

Projects

No open projects
Status: Done

Development

Successfully merging this pull request may close these issues.

5 participants