Skip to content

Use variadics_please to implement StableInterpolate on tuples.#16931

Merged
alice-i-cecile merged 2 commits intobevyengine:mainfrom
mweatherley:enumerate-macro
Dec 24, 2024
Merged

Use variadics_please to implement StableInterpolate on tuples.#16931
alice-i-cecile merged 2 commits intobevyengine:mainfrom
mweatherley:enumerate-macro

Conversation

@mweatherley
Copy link
Copy Markdown
Contributor

Objective

Now that variadics_please has a 1.1 release, we can re-implement the original solution.

Solution

Copy-paste the code from the original PR branch :)

@mweatherley mweatherley added C-Code-Quality A section of code that is hard to understand or change A-Math Fundamental domain-agnostic mathematical operations D-Straightforward Simple bug fixes and API improvements, docs, test and examples S-Needs-Review Needs reviewer attention (from anyone!) to move forward labels Dec 22, 2024
Copy link
Copy Markdown
Contributor

@BenjaminBrienen BenjaminBrienen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Double check that 1..11 is correct.

@alice-i-cecile alice-i-cecile added S-Ready-For-Final-Review This PR has been approved by the community. It's ready for a maintainer to consider merging it and removed S-Needs-Review Needs reviewer attention (from anyone!) to move forward labels Dec 22, 2024
@alice-i-cecile alice-i-cecile added this pull request to the merge queue Dec 24, 2024
Merged via the queue into bevyengine:main with commit ee9bea1 Dec 24, 2024
pcwalton pushed a commit to pcwalton/bevy that referenced this pull request Dec 25, 2024
…evyengine#16931)

# Objective

Now that `variadics_please` has a 1.1 release, we can re-implement the
original solution.

## Solution

Copy-paste the code from the [original
PR](bevyengine#15931) branch :)
ecoskey pushed a commit to ecoskey/bevy that referenced this pull request Jan 6, 2025
…evyengine#16931)

# Objective

Now that `variadics_please` has a 1.1 release, we can re-implement the
original solution.

## Solution

Copy-paste the code from the [original
PR](bevyengine#15931) branch :)
mrchantey pushed a commit to mrchantey/bevy that referenced this pull request Feb 4, 2025
…evyengine#16931)

# Objective

Now that `variadics_please` has a 1.1 release, we can re-implement the
original solution.

## Solution

Copy-paste the code from the [original
PR](bevyengine#15931) branch :)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

A-Math Fundamental domain-agnostic mathematical operations C-Code-Quality A section of code that is hard to understand or change D-Straightforward Simple bug fixes and API improvements, docs, test and examples S-Ready-For-Final-Review This PR has been approved by the community. It's ready for a maintainer to consider merging it

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants