Skip to content

Remove bevy_core#16897

Merged
alice-i-cecile merged 6 commits intobevyengine:mainfrom
bushrat011899:DestroyTheCore
Dec 19, 2024
Merged

Remove bevy_core#16897
alice-i-cecile merged 6 commits intobevyengine:mainfrom
bushrat011899:DestroyTheCore

Conversation

@bushrat011899
Copy link
Copy Markdown
Contributor

@bushrat011899 bushrat011899 commented Dec 19, 2024

Objective

Solution

  • Removed TypeRegistryPlugin (Name is now automatically registered with a default App)
  • Moved TaskPoolPlugin to bevy_app
  • Moved FrameCountPlugin to bevy_diagnostic
  • Deleted now-empty bevy_core

Testing

  • CI

Migration Guide

  • TypeRegistryPlugin no longer exists. If you can't use a default App but still need Name registered, do so manually with app.register_type::<Name>().
  • References to TaskPoolPlugin and associated types will need to import it from bevy_app instead of bevy_core
  • References to FrameCountPlugin and associated types will need to import it from bevy_diagnostic instead of bevy_core

Notes

This strategy was agreed upon by Cart and several other members in Discord.

@bushrat011899 bushrat011899 added D-Trivial Nice and easy! A great choice to get started with Bevy C-Code-Quality A section of code that is hard to understand or change A-Core X-Blessed Has a large architectural impact or tradeoffs, but the design has been endorsed by decision makers S-Needs-Review Needs reviewer attention (from anyone!) to move forward labels Dec 19, 2024
@bushrat011899
Copy link
Copy Markdown
Contributor Author

bushrat011899 commented Dec 19, 2024

I've marked this as X-Blessed based on Cart's approval of my proposal, but please remove it if that's inappropriate!

aevyrie
aevyrie approved these changes Dec 19, 2024
View reviewed changes
Copy link
Copy Markdown
Member

@aevyrie aevyrie left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Probably worth noting the path change to Name for people migrating their scene files.

@ItsDoot
Copy link
Copy Markdown
Contributor

ItsDoot commented Dec 19, 2024

Probably worth noting the path change to Name for people migrating their scene files.

That should be covered by the migration guide in #16894

@bushrat011899
Copy link
Copy Markdown
Contributor Author

bushrat011899 commented Dec 19, 2024

Probably worth noting the path change to Name for people migrating their scene files.

Yeah as @ItsDoot mentioned it's covered by #16894's migration guide. I just missed this instance and it slipped through CI, so I fixed it here since it's somewhat related.

@bushrat011899 bushrat011899 added S-Ready-For-Final-Review This PR has been approved by the community. It's ready for a maintainer to consider merging it and removed S-Needs-Review Needs reviewer attention (from anyone!) to move forward labels Dec 19, 2024
@bushrat011899 bushrat011899 mentioned this pull request Dec 19, 2024
Closed
@alice-i-cecile alice-i-cecile added this pull request to the merge queue Dec 19, 2024
@alice-i-cecile alice-i-cecile mentioned this pull request Dec 19, 2024
Closed
Merged via the queue into bevyengine:main with commit 2178663 Dec 19, 2024
ecoskey pushed a commit to ecoskey/bevy that referenced this pull request Jan 6, 2025
@bushrat011899 @ecoskey
Remove bevy_core (bevyengine#16897)
a21b4e8 
# Objective

- Fixes bevyengine#16892

## Solution

- Removed `TypeRegistryPlugin` (`Name` is now automatically registered
with a default `App`)
- Moved `TaskPoolPlugin` to `bevy_app`
- Moved `FrameCountPlugin` to `bevy_diagnostic`
- Deleted now-empty `bevy_core`

## Testing

- CI

## Migration Guide

- `TypeRegistryPlugin` no longer exists. If you can't use a default
`App` but still need `Name` registered, do so manually with
`app.register_type::<Name>()`.
- References to `TaskPoolPlugin` and associated types will need to
import it from `bevy_app` instead of `bevy_core`
- References to `FrameCountPlugin` and associated types will need to
import it from `bevy_diagnostic` instead of `bevy_core`

## Notes

This strategy was agreed upon by Cart and several other members in
[Discord](https://discord.com/channels/691052431525675048/692572690833473578/1319137218312278077).
mrchantey pushed a commit to mrchantey/bevy that referenced this pull request Feb 4, 2025
@bushrat011899 @mrchantey
Remove bevy_core (bevyengine#16897)
04ea6b1 
# Objective

- Fixes bevyengine#16892

## Solution

- Removed `TypeRegistryPlugin` (`Name` is now automatically registered
with a default `App`)
- Moved `TaskPoolPlugin` to `bevy_app`
- Moved `FrameCountPlugin` to `bevy_diagnostic`
- Deleted now-empty `bevy_core`

## Testing

- CI

## Migration Guide

- `TypeRegistryPlugin` no longer exists. If you can't use a default
`App` but still need `Name` registered, do so manually with
`app.register_type::<Name>()`.
- References to `TaskPoolPlugin` and associated types will need to
import it from `bevy_app` instead of `bevy_core`
- References to `FrameCountPlugin` and associated types will need to
import it from `bevy_diagnostic` instead of `bevy_core`

## Notes

This strategy was agreed upon by Cart and several other members in
[Discord](https://discord.com/channels/691052431525675048/692572690833473578/1319137218312278077).
JasmineLowen added a commit to joseph-gio/bevy-trait-query that referenced this pull request Mar 20, 2025
@JasmineLowen
chore: bump to v0.16.0-rc.1 and remove bevy_core
ef7f565 
- bevy_core was removed upstream in bevyengine/bevy#16897
- we actually just used bevy_core for `Name` which is now exposed
  through bevy_ecs
@JasmineLowen JasmineLowen mentioned this pull request Mar 20, 2025
Merged
JasmineLowen added a commit to joseph-gio/bevy-trait-query that referenced this pull request Mar 20, 2025
@JasmineLowen
chore: bump to v0.16.0-rc.1 and remove bevy_core
5c2e296 
- bevy_core was removed upstream in bevyengine/bevy#16897
- we actually just used bevy_core for `Name` which is now exposed
  through bevy_ecs
JasmineLowen added a commit to joseph-gio/bevy-trait-query that referenced this pull request Apr 25, 2025
@JasmineLowen
chore: update to 0.16 🎉
39d64f2 
Some notes:

- bevy_core was removed upstream in bevyengine/bevy#16897
- we actually just used bevy_core for `Name` which is now exposed
  through bevy_ecs
JasmineLowen added a commit to joseph-gio/bevy-trait-query that referenced this pull request Apr 25, 2025
@JasmineLowen
chore: update to 0.16 🎉
6df768a 
Some notes:

- bevy_core was removed upstream in bevyengine/bevy#16897
- we actually just used bevy_core for `Name` which is now exposed
  through bevy_ecs
salixsalicaceae pushed a commit to fslabs/bevy that referenced this pull request Mar 26, 2026
@bushrat011899
Remove bevy_core (bevyengine#16897)
3297977 
# Objective

- Fixes bevyengine#16892

## Solution

- Removed `TypeRegistryPlugin` (`Name` is now automatically registered
with a default `App`)
- Moved `TaskPoolPlugin` to `bevy_app`
- Moved `FrameCountPlugin` to `bevy_diagnostic`
- Deleted now-empty `bevy_core`

## Testing

- CI

## Migration Guide

- `TypeRegistryPlugin` no longer exists. If you can't use a default
`App` but still need `Name` registered, do so manually with
`app.register_type::<Name>()`.
- References to `TaskPoolPlugin` and associated types will need to
import it from `bevy_app` instead of `bevy_core`
- References to `FrameCountPlugin` and associated types will need to
import it from `bevy_diagnostic` instead of `bevy_core`

## Notes

This strategy was agreed upon by Cart and several other members in
[Discord](https://discord.com/channels/691052431525675048/692572690833473578/1319137218312278077).
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@alice-i-cecile alice-i-cecile Awaiting requested review from alice-i-cecile

@BenjaminBrienen BenjaminBrienen Awaiting requested review from BenjaminBrienen

2 more reviewers

@aevyrie aevyrie aevyrie approved these changes

@ItsDoot ItsDoot ItsDoot approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

C-Code-Quality A section of code that is hard to understand or change D-Trivial Nice and easy! A great choice to get started with Bevy S-Ready-For-Final-Review This PR has been approved by the community. It's ready for a maintainer to consider merging it X-Blessed Has a large architectural impact or tradeoffs, but the design has been endorsed by decision makers

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Split up bevy_core

4 participants

@bushrat011899 @ItsDoot @aevyrie @alice-i-cecile