Skip to content

Update rodio requirement from 0.19 to 0.20#16359

Merged
alice-i-cecile merged 1 commit intobevyengine:mainfrom
mnmaita:mnmaita/cargo/rodio-0.20
Dec 3, 2024
Merged

Update rodio requirement from 0.19 to 0.20#16359
alice-i-cecile merged 1 commit intobevyengine:mainfrom
mnmaita:mnmaita/cargo/rodio-0.20

Conversation

@mnmaita
Copy link
Copy Markdown
Member

@mnmaita mnmaita commented Nov 11, 2024

Objective

Solution

  • Updated rodio version requirement to 0.20.
  • Changelog

Testing

  • CI checks.

@mnmaita mnmaita added C-Dependencies A change to the crates that Bevy depends on D-Straightforward Simple bug fixes and API improvements, docs, test and examples S-Needs-Review Needs reviewer attention (from anyone!) to move forward labels Nov 11, 2024
@dependabot @mnmaita
Update rodio requirement from 0.19 to 0.20
96f6c21 
Updates the requirements on [rodio](https://github.com/RustAudio/rodio) to permit the latest version.
- [Changelog](https://github.com/RustAudio/rodio/blob/master/CHANGELOG.md)
- [Commits](RustAudio/rodio@v0.19.0...v0.20.1)

---
updated-dependencies:
- dependency-name: rodio
  dependency-type: direct:production
...

Signed-off-by: dependabot[bot] <support@github.com>
@mnmaita mnmaita force-pushed the mnmaita/cargo/rodio-0.20 branch from 3f1a049 to 96f6c21 Compare November 11, 2024 23:55
@mnmaita mnmaita mentioned this pull request Nov 11, 2024
Closed
@mnmaita
Copy link
Copy Markdown
Member Author

mnmaita commented Nov 12, 2024

The check-advisories failure is unrelated and also currently present in main. It will be fixed when notify-types gets bumped to v2.0.

@alice-i-cecile alice-i-cecile added the A-Audio Sounds playback and modification label Nov 12, 2024
@alice-i-cecile alice-i-cecile added this to the 0.16 milestone Nov 12, 2024
@alice-i-cecile alice-i-cecile added S-Ready-For-Final-Review This PR has been approved by the community. It's ready for a maintainer to consider merging it and removed S-Needs-Review Needs reviewer attention (from anyone!) to move forward labels Nov 12, 2024
@alice-i-cecile
Copy link
Copy Markdown
Member

alice-i-cecile commented Nov 12, 2024

Bumping to 0.16: this shouldn't be shipped without testing.

@alice-i-cecile alice-i-cecile added this pull request to the merge queue Dec 3, 2024
Merged via the queue into bevyengine:main with commit bfb2ff1 Dec 3, 2024
@mnmaita mnmaita deleted the mnmaita/cargo/rodio-0.20 branch December 4, 2024 00:13
ecoskey pushed a commit to ecoskey/bevy that referenced this pull request Jan 6, 2025
@mnmaita @dependabot @ecoskey
Update rodio requirement from 0.19 to 0.20 (bevyengine#16359)
ddfac2e 
# Objective

- Supersedes bevyengine#16344

## Solution

- Updated `rodio` version requirement to `0.20`.
-
[Changelog](https://github.com/RustAudio/rodio/blob/master/CHANGELOG.md)

## Testing

- CI checks.

Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@alice-i-cecile alice-i-cecile alice-i-cecile approved these changes

+1 more reviewer

@BenjaminBrienen BenjaminBrienen BenjaminBrienen approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

A-Audio Sounds playback and modification C-Dependencies A change to the crates that Bevy depends on D-Straightforward Simple bug fixes and API improvements, docs, test and examples S-Ready-For-Final-Review This PR has been approved by the community. It's ready for a maintainer to consider merging it

Projects

No open projects
Audio (Old)
Status: Done

Milestone

0.16

Development

Successfully merging this pull request may close these issues.

3 participants

@mnmaita @alice-i-cecile @BenjaminBrienen