Fix screenshot comparison#15894
Merged
alice-i-cecile merged 7 commits intobevyengine:mainfrom Oct 14, 2024
Merged
Conversation
BenjaminBrienen
approved these changes
Oct 14, 2024
BD103
reviewed
Oct 14, 2024
Member
Author
|
@BD103 I reverted the parts that used a It's still kinda hard to make sure everything will work fine as it uses the workflow definition from main, not from the PR |
BD103
approved these changes
Oct 14, 2024
Member
BD103
left a comment
There was a problem hiding this comment.
Looks good, though we'll have to see if it works once this gets merged. :)
| var artifacts = await github.rest.actions.listWorkflowRunArtifacts({ | ||
| owner: context.repo.owner, | ||
| repo: context.repo.repo, | ||
| run_id: ${{github.event.workflow_run.id }}, |
Member
There was a problem hiding this comment.
Suggested change
| run_id: ${{github.event.workflow_run.id }}, | |
| run_id: ${{ github.event.workflow_run.id }}, |
(Nit) Add a space to make it symmetric.
| with: | ||
| name: screenshots-macos | ||
| path: screenshots-macos | ||
|
|
Member
There was a problem hiding this comment.
Suggested change
(Nit) There was an extra newline here :)
github-merge-queue bot
pushed a commit
that referenced
this pull request
Oct 14, 2024
… upload-artifact action (#15911) # Objective - After #15894, creenshot upload now works on linux but still fails on macOS - Artifact with screenshot is not prepared correctly:  ## Solution - Try to prepare it like the `upload-artifact` action expects it
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Objective
Solution
workflow_runevent to upload screenshotsTesting