Fix AssetServer lifetimes#15533
Merged
alice-i-cecile merged 2 commits intobevyengine:mainfrom Sep 30, 2024
Merged
Conversation
Contributor
|
Welcome, new contributor! Please make sure you've read our contributing guide and we look forward to reviewing your pull request shortly ✨ |
alice-i-cecile
approved these changes
Sep 30, 2024
SpecificProtagonist
approved these changes
Sep 30, 2024
kristoff3r
reviewed
Sep 30, 2024
Contributor
kristoff3r
left a comment
There was a problem hiding this comment.
I might be missing something, but I think these can be simplified. There's also other functions in the same file that has unused 'a lifetimes.
Comment on lines
+221
to
+223
| pub async fn get_path_asset_loader<'a, 'b>( | ||
| &self, | ||
| path: impl Into<AssetPath<'a>>, | ||
| path: impl Into<AssetPath<'b>>, |
Contributor
There was a problem hiding this comment.
I don't understand, doesn't this mean the same thing? Also 'a is no longer used.
Comment on lines
+134
to
137
| pub fn get_source<'a, 'b>( | ||
| &'a self, | ||
| source: impl Into<AssetSourceId<'a>>, | ||
| source: impl Into<AssetSourceId<'b>>, | ||
| ) -> Result<&'a AssetSource, MissingAssetSourceError> { |
Contributor
There was a problem hiding this comment.
Can't this be written as (I can't do a suggestion because it touches unchanged lines)
pub fn get_source<'a>(
&self,
source: impl Into<AssetSourceId<'a>>,
) -> Result<&AssetSource, MissingAssetSourceError> {
robtfm
pushed a commit
to robtfm/bevy
that referenced
this pull request
Oct 4, 2024
# Objective - Adds a separate lifetimes for AssetSourceId
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Objective