Skip to content

Fix regression in bevy_gltf build#15512

Merged
alice-i-cecile merged 2 commits intobevyengine:mainfrom
BenjaminBrienen:fix-gltf-import
Sep 29, 2024
Merged

Fix regression in bevy_gltf build#15512
alice-i-cecile merged 2 commits intobevyengine:mainfrom
BenjaminBrienen:fix-gltf-import

Conversation

@BenjaminBrienen
Copy link
Copy Markdown
Contributor

@BenjaminBrienen BenjaminBrienen commented Sep 29, 2024

Objective

Fixes #15503

Solution

Move the use

Testing

Compiled with cargo build --no-default-features --features bevy_gltf successfully.

Showcase

image

@BenjaminBrienen BenjaminBrienen self-assigned this Sep 29, 2024
@BenjaminBrienen BenjaminBrienen added C-Bug An unexpected or incorrect behavior D-Trivial Nice and easy! A great choice to get started with Bevy S-Needs-Review Needs reviewer attention (from anyone!) to move forward A-glTF Related to the glTF 3D scene/model format labels Sep 29, 2024
@alice-i-cecile alice-i-cecile added S-Ready-For-Final-Review This PR has been approved by the community. It's ready for a maintainer to consider merging it and removed S-Needs-Review Needs reviewer attention (from anyone!) to move forward labels Sep 29, 2024
@alice-i-cecile alice-i-cecile added this to the 0.15 milestone Sep 29, 2024
@alice-i-cecile
Copy link
Copy Markdown
Member

alice-i-cecile commented Sep 29, 2024

Clippy's mad at you now :p

@BenjaminBrienen
Copy link
Copy Markdown
Contributor Author

BenjaminBrienen commented Sep 29, 2024

I apologized and we made up

@alice-i-cecile alice-i-cecile added this pull request to the merge queue Sep 29, 2024
Merged via the queue into bevyengine:main with commit bd20382 Sep 29, 2024
@BenjaminBrienen BenjaminBrienen deleted the fix-gltf-import branch September 29, 2024 11:57
robtfm pushed a commit to robtfm/bevy that referenced this pull request Oct 4, 2024
@BenjaminBrienen @robtfm
Fix regression in bevy_gltf build (bevyengine#15512)
ce4cde5 
# Objective

Fixes bevyengine#15503

## Solution

Move the use

## Testing

Compiled with `cargo build --no-default-features --features bevy_gltf`
successfully.

## Showcase


![image](https://github.com/user-attachments/assets/b5637e0e-2af9-4b8e-bf24-b378775d3f10)
@BenjaminBrienen BenjaminBrienen removed the S-Ready-For-Final-Review This PR has been approved by the community. It's ready for a maintainer to consider merging it label Nov 10, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@alice-i-cecile alice-i-cecile alice-i-cecile approved these changes

Assignees

@BenjaminBrienen BenjaminBrienen

Labels

A-glTF Related to the glTF 3D scene/model format C-Bug An unexpected or incorrect behavior D-Trivial Nice and easy! A great choice to get started with Bevy

Projects

None yet

Milestone

0.15

Development

Successfully merging this pull request may close these issues.

Regression in bevy_gltf build

2 participants

@BenjaminBrienen @alice-i-cecile