Add register_resource_with_descriptor#15501
Merged
alice-i-cecile merged 4 commits intobevyengine:mainfrom Sep 30, 2024
Merged
Conversation
pablo-lua
reviewed
Sep 28, 2024
Contributor
MichalGniadek
left a comment
There was a problem hiding this comment.
Would it make sense to also use it in the custom_resource_with_layout test?
Member
Author
I had this originally, but decided to keep it as is. After mulling it over though I think I'm in agreement. |
pablo-lua
approved these changes
Sep 28, 2024
BenjaminBrienen
approved these changes
Sep 29, 2024
MichalGniadek
approved these changes
Sep 29, 2024
robtfm
pushed a commit
to robtfm/bevy
that referenced
this pull request
Oct 4, 2024
# Objective - Fixes bevyengine#15448. ## Solution - Add `World::register_resource_with_descriptor` and `Components::register_resource_with_descriptor`. ## Testing - Added a test `dynamic_resource`.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Objective
init_resource_with_descriptor#15448.Solution
World::register_resource_with_descriptorandComponents::register_resource_with_descriptor.Testing
dynamic_resource.