Clarify purpose of shader_instancing example#15456
Merged
alice-i-cecile merged 6 commits intobevyengine:mainfrom Sep 30, 2024
Merged
Clarify purpose of shader_instancing example#15456alice-i-cecile merged 6 commits intobevyengine:mainfrom
alice-i-cecile merged 6 commits intobevyengine:mainfrom
Conversation
ChristopherBiscardi
approved these changes
Sep 26, 2024
Contributor
ChristopherBiscardi
left a comment
There was a problem hiding this comment.
common question answered in the place the people asking are likely looking
tychedelia
approved these changes
Sep 26, 2024
Member
tychedelia
left a comment
There was a problem hiding this comment.
Hopefully will avoid a lot of confusion in the future!
JMS55
reviewed
Sep 27, 2024
JMS55
reviewed
Sep 27, 2024
JMS55
approved these changes
Sep 27, 2024
Contributor
JMS55
left a comment
There was a problem hiding this comment.
Approved with some minor suggested tweaks to wording
Co-authored-by: JMS55 <47158642+JMS55@users.noreply.github.com>
alice-i-cecile
approved these changes
Sep 30, 2024
robtfm
pushed a commit
to robtfm/bevy
that referenced
this pull request
Oct 4, 2024
# Objective - The shader_instancing example can be misleading since it doesn't explain that bevy has built in automatic instancing. ## Solution - Explain that bevy has built in instancing and that this example is for advanced users. - Add a new automatic_instancing example that shows how to use the built in automatic instancing - Rename the shader_instancing example to custom_shader_instancing to highlight that this is a more advanced implementation --------- Co-authored-by: JMS55 <47158642+JMS55@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Objective
Solution