Implement volumetric fog support for both point lights and spotlights#15361
Merged
alice-i-cecile merged 6 commits intobevyengine:mainfrom Sep 29, 2024
Merged
Implement volumetric fog support for both point lights and spotlights#15361alice-i-cecile merged 6 commits intobevyengine:mainfrom
alice-i-cecile merged 6 commits intobevyengine:mainfrom
Conversation
95b4ba4 to
be5376a
Compare
Member
alice-i-cecile
left a comment
There was a problem hiding this comment.
Nothing blocking, but a few questions and suggestions. I'll leave the full reviews to the rendering experts, but I'm very pleased to see this!
tychedelia
reviewed
Sep 22, 2024
Contributor
Author
|
Hi @alice-i-cecile and @tychedelia , thank you for the guidance. I have refactored the code and added some UI options for the volumetric fog example. Could you please help review this again? Thank you. |
IceSentry
reviewed
Sep 23, 2024
IceSentry
reviewed
Sep 23, 2024
IceSentry
approved these changes
Sep 23, 2024
d7df0ff to
adc2cea
Compare
tychedelia
approved these changes
Sep 29, 2024
Member
tychedelia
left a comment
There was a problem hiding this comment.
Verified all the fog examples work.
MiniaczQ
pushed a commit
to MiniaczQ/bevy
that referenced
this pull request
Sep 30, 2024
…bevyengine#15361) # Objective - Fixes: bevyengine#14451 ## Solution - Adding volumetric fog sampling code for both point lights and spotlights. ## Testing - I have modified the example of volumetric_fog.rs by adding a volumetric point light and a volumetric spotlight. https://github.com/user-attachments/assets/3eeb77a0-f22d-40a6-a48a-2dd75d55a877
robtfm
pushed a commit
to robtfm/bevy
that referenced
this pull request
Oct 4, 2024
…bevyengine#15361) # Objective - Fixes: bevyengine#14451 ## Solution - Adding volumetric fog sampling code for both point lights and spotlights. ## Testing - I have modified the example of volumetric_fog.rs by adding a volumetric point light and a volumetric spotlight. https://github.com/user-attachments/assets/3eeb77a0-f22d-40a6-a48a-2dd75d55a877
Member
|
Thank you to everyone involved with the authoring or reviewing of this PR! This work is relatively important and needs release notes! Head over to bevyengine/bevy-website#1702 if you'd like to help out. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Objective
Solution
Testing
volumetric_fog.mov