Skip to content

Clear view attachments before resizing window surfaces#15087

Merged
alice-i-cecile merged 2 commits intobevyengine:mainfrom
akimakinai:clear_view_attachments
Sep 30, 2024
Merged

Clear view attachments before resizing window surfaces#15087
alice-i-cecile merged 2 commits intobevyengine:mainfrom
akimakinai:clear_view_attachments

Conversation

@akimakinai
Copy link
Copy Markdown
Contributor

@akimakinai akimakinai commented Sep 8, 2024 •
edited
Loading

Objective

Solution

  • Clears ViewTargetAttachments resource every frame before create_surfaces system instead, which was previously done after extract_windows.

Testing

  • Confirmed that examples no longer panic on window resizing with DX12 backend.
  • screenshot example keeps working after this change.

@JMS55
Copy link
Copy Markdown
Contributor

JMS55 commented Sep 8, 2024

I'm not convinced that this is correct. It seems more like something we need wgpu to clarify first, if not a wgpu issue.

@akimakinai akimakinai closed this Sep 8, 2024
@akimakinai akimakinai mentioned this pull request Sep 8, 2024
Closed
@akimakinai akimakinai reopened this Sep 9, 2024
@akimakinai akimakinai mentioned this pull request Sep 9, 2024
Closed
@alice-i-cecile alice-i-cecile added C-Bug An unexpected or incorrect behavior A-Rendering Drawing game state to the screen S-Needs-Design This issue requires design work to think about how it would best be accomplished labels Sep 9, 2024
@JMS55 JMS55 added D-Straightforward Simple bug fixes and API improvements, docs, test and examples S-Needs-Review Needs reviewer attention (from anyone!) to move forward and removed S-Needs-Design This issue requires design work to think about how it would best be accomplished labels Sep 10, 2024
@IceSentry IceSentry added S-Ready-For-Final-Review This PR has been approved by the community. It's ready for a maintainer to consider merging it and removed S-Needs-Review Needs reviewer attention (from anyone!) to move forward labels Sep 26, 2024
@alice-i-cecile alice-i-cecile added this pull request to the merge queue Sep 30, 2024
Merged via the queue into bevyengine:main with commit 2ec164d Sep 30, 2024
robtfm pushed a commit to robtfm/bevy that referenced this pull request Oct 4, 2024
@akimakinai @robtfm
Clear view attachments before resizing window surfaces (bevyengine#15087
714971c 
)

# Objective

- Fixes bevyengine#15077

## Solution

- Clears `ViewTargetAttachments` resource every frame before
`create_surfaces` system instead, which was previously done after
`extract_windows`.

## Testing

- Confirmed that examples no longer panic on window resizing with DX12
backend.
- `screenshot` example keeps working after this change.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

4 more reviewers

@kristoff3r kristoff3r kristoff3r approved these changes

@IceSentry IceSentry IceSentry approved these changes

@BenjaminBrienen BenjaminBrienen BenjaminBrienen approved these changes

@JMS55 JMS55 JMS55 approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

A-Rendering Drawing game state to the screen C-Bug An unexpected or incorrect behavior D-Straightforward Simple bug fixes and API improvements, docs, test and examples S-Ready-For-Final-Review This PR has been approved by the community. It's ready for a maintainer to consider merging it

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

DX12 backend panics when window is resized

6 participants

@akimakinai @JMS55 @kristoff3r @IceSentry @BenjaminBrienen @alice-i-cecile