Skip to content

remove DeterministicRenderingConfig#12811

Merged
james7132 merged 2 commits intobevyengine:mainfrom
mockersf:remove-deterministic-config
Apr 1, 2024
Merged

remove DeterministicRenderingConfig#12811
james7132 merged 2 commits intobevyengine:mainfrom
mockersf:remove-deterministic-config

Conversation

@mockersf
Copy link
Copy Markdown
Member

@mockersf mockersf commented Mar 31, 2024

Objective

Solution

  • Remove it

Migration Guide

  • Removed DeterministicRenderingConfig. There shouldn't be any z fighting anymore in the rendering even without setting stable_sort_z_fighting

@mockersf mockersf added the A-Rendering Drawing game state to the screen label Mar 31, 2024
@mockersf mockersf added this to the 0.14 milestone Mar 31, 2024
@mockersf mockersf added the M-Migration-Guide A breaking change to Bevy's public API that needs to be noted in a migration guide label Mar 31, 2024
@github-actions
Copy link
Copy Markdown
Contributor

github-actions bot commented Mar 31, 2024

The generated examples/README.md is out of sync with the example metadata in Cargo.toml or the example readme template. Please run cargo run -p build-templated-pages -- update examples to update it, and commit the file change.

@james7132
Copy link
Copy Markdown
Member

james7132 commented Mar 31, 2024

Doesn't this still affect the sorted render phases?

@re0312
Copy link
Copy Markdown
Contributor

re0312 commented Apr 1, 2024

looks like it is still required for transparent material, but example regarding the deterministic option should be updated. for long-term consideration, im not in favor of keeping it. the determinismis configured by DeterministicRenderingConfig more of an issue with Bevy's parallelizer rather than a rendering related,Could we track the order when splitting tasks in par_for_each instead of sorting all visible_entities after iteration?

@mockersf
Copy link
Copy Markdown
Member Author

mockersf commented Apr 1, 2024

If I introduce a little shift in the transforms of the deterministic example, it looks like
Screenshot 2024-04-01 at 09 27 59

and... it's not deterministic anymore, how it looks will change every time it's run

looks like it is still required for transparent material

Right, with a transparent material it works as expected

We already have a tool against z fighting it's depth_bias

james7132
james7132 approved these changes Apr 1, 2024
View reviewed changes
Copy link
Copy Markdown
Member

@james7132 james7132 left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ah right momentarily forgot about that, thanks. LGTM.

@james7132 james7132 added this pull request to the merge queue Apr 1, 2024
Merged via the queue into bevyengine:main with commit 93fd02e Apr 1, 2024
chompaa pushed a commit to chompaa/bevy that referenced this pull request Apr 5, 2024
@mockersf @chompaa
remove DeterministicRenderingConfig (bevyengine#12811)
d23ca61 
# Objective

- Since bevyengine#12453, `DeterministicRenderingConfig` doesn't do anything

## Solution

- Remove it

---

## Migration Guide

- Removed `DeterministicRenderingConfig`. There shouldn't be any z
fighting anymore in the rendering even without setting
`stable_sort_z_fighting`
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@james7132 james7132 james7132 approved these changes

Assignees

No one assigned

Labels

A-Rendering Drawing game state to the screen M-Migration-Guide A breaking change to Bevy's public API that needs to be noted in a migration guide

Projects

None yet

Milestone

0.14

Development

Successfully merging this pull request may close these issues.

3 participants

@mockersf @james7132 @re0312