Document ButtonInput behavior regarding window focus#12367
Merged
alice-i-cecile merged 2 commits intobevyengine:mainfrom Mar 8, 2024
Merged
Document ButtonInput behavior regarding window focus#12367alice-i-cecile merged 2 commits intobevyengine:mainfrom
alice-i-cecile merged 2 commits intobevyengine:mainfrom
Conversation
matiqo15
approved these changes
Mar 7, 2024
Member
matiqo15
left a comment
There was a problem hiding this comment.
Just some suggestions, overall looks good!
Co-authored-by: Mateusz Wachowiak <mateusz_wachowiak@outlook.com>
alice-i-cecile
approved these changes
Mar 7, 2024
Member
alice-i-cecile
left a comment
There was a problem hiding this comment.
Cursed, but a useful note for now.
spectria-limina
pushed a commit
to spectria-limina/bevy
that referenced
this pull request
Mar 9, 2024
# Objective `ButtonInput<KeyCode>` documentation is currently incorrect/incomplete, see bevyengine#12273. ## Solution Fix the documentation. I think in the future we should also stop triggering `just_pressed`/`just_released` when focus switches between two Bevy windows, as those functions are independent of the window. It could also make sense to add individual `ButtonInput<KeyCode>`s per window. --------- Co-authored-by: Mateusz Wachowiak <mateusz_wachowiak@outlook.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Objective
ButtonInput<KeyCode>documentation is currently incorrect/incomplete, see #12273.Solution
Fix the documentation.
I think in the future we should also stop triggering
just_pressed/just_releasedwhen focus switches between two Bevy windows, as those functions are independent of the window. It could also make sense to add individualButtonInput<KeyCode>s per window.