Skip to content

Fix duplicate dependencies on raw-window-handle#12309

Merged
mockersf merged 2 commits intobevyengine:mainfrom
ameknite:remove-skip-crate-in-deny.toml
Mar 5, 2024
Merged

Fix duplicate dependencies on raw-window-handle#12309
mockersf merged 2 commits intobevyengine:mainfrom
ameknite:remove-skip-crate-in-deny.toml

Conversation

@ameknite
Copy link
Copy Markdown
Contributor

@ameknite ameknite commented Mar 5, 2024

Objective

cpal has been updated to 0.15.3. we can remove the skip to avoid check for cpal 0.15.2 dependencies in deny.toml

cpal now uses ndk 8.0 and Oboe 6.0, so we only have a version for raw-window-handle, version 0.6

Solution

  • Remove temporal fix that skipped the check for the cpal dependency.
  • Update oboe to 0.6

Fixes #11917

@alice-i-cecile alice-i-cecile requested a review from mockersf March 5, 2024 02:35
@alice-i-cecile alice-i-cecile added A-Build-System Related to build systems or continuous integration C-Dependencies A change to the crates that Bevy depends on labels Mar 5, 2024
@james7132 james7132 added the S-Ready-For-Final-Review This PR has been approved by the community. It's ready for a maintainer to consider merging it label Mar 5, 2024
@mockersf mockersf added this pull request to the merge queue Mar 5, 2024
Merged via the queue into bevyengine:main with commit ee2fdc0 Mar 5, 2024
spectria-limina pushed a commit to spectria-limina/bevy that referenced this pull request Mar 9, 2024
# Objective

cpal has been updated to [0.15.3](https://crates.io/crates/cpal/0.15.3).
we can remove the skip to avoid check for cpal 0.15.2 dependencies in
deny.toml

cpal now uses ndk 8.0 and Oboe 6.0, so we only have a version for
raw-window-handle, version 0.6

## Solution

- Remove temporal fix that skipped the check for the cpal dependency.
- Update oboe to 0.6

Fixes bevyengine#11917
mtsr pushed a commit to mtsr/bevy that referenced this pull request Mar 15, 2024
# Objective

cpal has been updated to [0.15.3](https://crates.io/crates/cpal/0.15.3).
we can remove the skip to avoid check for cpal 0.15.2 dependencies in
deny.toml

cpal now uses ndk 8.0 and Oboe 6.0, so we only have a version for
raw-window-handle, version 0.6

## Solution

- Remove temporal fix that skipped the check for the cpal dependency.
- Update oboe to 0.6

Fixes bevyengine#11917
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

A-Build-System Related to build systems or continuous integration C-Dependencies A change to the crates that Bevy depends on S-Ready-For-Final-Review This PR has been approved by the community. It's ready for a maintainer to consider merging it

Projects

None yet

Development

Successfully merging this pull request may close these issues.

CI "check-bans" check fails due to duplicate dependencies on raw-window-handle

6 participants