Hash stability guarantees#11690
Merged
alice-i-cecile merged 2 commits intobevyengine:mainfrom Feb 5, 2024
Merged
Conversation
alice-i-cecile
approved these changes
Feb 4, 2024
Member
|
I'm tentatively in favor of marking |
NthTensor
approved these changes
Feb 5, 2024
tjamaan
pushed a commit
to tjamaan/bevy
that referenced
this pull request
Feb 6, 2024
# Objective We currently over/underpromise hash stability: - `HashMap`/`HashSet` use `BuildHasherDefault<AHasher>` instead of `RandomState`. As a result, the hash is stable within the same run. - [aHash isn't stable between devices (and versions)](https://github.com/tkaitchuck/ahash?tab=readme-ov-file#goals-and-non-goals), yet it's used for `StableHashMap`/`StableHashSet` - the specialized hashmaps are stable Interestingly, `StableHashMap`/`StableHashSet` aren't used by Bevy itself (anymore). ## Solution Add/fix documentation ## Alternatives For `StableHashMap`/`StableHashSet`: - remove them - revive bevyengine#7107 --- ## Changelog - added iteration stability guarantees for different hashmaps
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Objective
We currently over/underpromise hash stability:
HashMap/HashSetuseBuildHasherDefault<AHasher>instead ofRandomState. As a result, the hash is stable within the same run.StableHashMap/StableHashSetInterestingly,
StableHashMap/StableHashSetaren't used by Bevy itself (anymore).Solution
Add/fix documentation
Alternatives
For
StableHashMap/StableHashSet:Changelog