Workaround for ICE in the DXC shader compiler in debug builds with an EnvironmentMapLight#11487
Merged
mockersf merged 2 commits intobevyengine:mainfrom Jan 27, 2024
Merged
Workaround for ICE in the DXC shader compiler in debug builds with an EnvironmentMapLight#11487mockersf merged 2 commits intobevyengine:mainfrom
EnvironmentMapLight#11487mockersf merged 2 commits intobevyengine:mainfrom
Conversation
Contributor
|
Can we leave a commented-out |
JMS55
approved these changes
Jan 24, 2024
atlv24
approved these changes
Jan 27, 2024
IceSentry
approved these changes
Jan 27, 2024
mockersf
approved these changes
Jan 27, 2024
tjamaan
pushed a commit
to tjamaan/bevy
that referenced
this pull request
Feb 6, 2024
… `EnvironmentMapLight` (bevyengine#11487) # Objective DXC+DX12 debug builds with an environment map have been broken since bevyengine#11366 merged due to an internal compiler error in DXC. I tracked it down to a single `break` statement and reported it upstream (microsoft/DirectXShaderCompiler#6183) ## Solution Workaround the ICE by setting the for loop index variable to the max value of the loop to avoid the `break` that's causing the ICE. This works because it's the last thing in the for loop. The `reflection_probes` and `pbr` examples both appear to still work correctly.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
7 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Objective
DXC+DX12 debug builds with an environment map have been broken since #11366 merged due to an internal compiler error in DXC. I tracked it down to a single
breakstatement and reported it upstream (microsoft/DirectXShaderCompiler#6183)Solution
Workaround the ICE by setting the for loop index variable to the max value of the loop to avoid the
breakthat's causing the ICE.This works because it's the last thing in the for loop.
The
reflection_probesandpbrexamples both appear to still work correctly.