Add [lints] table, fix adding #![allow(clippy::type_complexity)] everywhere#10011
Add [lints] table, fix adding #![allow(clippy::type_complexity)] everywhere#10011alice-i-cecile merged 13 commits intobevyengine:mainfrom
#![allow(clippy::type_complexity)] everywhere#10011Conversation
|
blocked until Rust 1.74 is stable - 16 November, 2023 |
c6dfa17 to
0c7dd89
Compare
|
You added a new example but didn't add metadata for it. Please update the root Cargo.toml file. |
2 similar comments
|
You added a new example but didn't add metadata for it. Please update the root Cargo.toml file. |
|
You added a new example but didn't add metadata for it. Please update the root Cargo.toml file. |
b159038 to
13a5ee3
Compare
|
No longer blocked! |
Co-authored-by: Martín Maita <47983254+mnmaita@users.noreply.github.com>
bd047cd to
c0272c6
Compare
|
Should this bump the MSRV? I guess we're ok in CI since we're always using latest. Bevy contributors, I guess might get failures in CI that they don't see locally if they're using an older version. I would say we should bump it, but it's not necessarily required here. |
|
I'm slightly unsure about using workspace lints in example files (definitely makes sense everywhere else) because it might confuse someone reading and copying the examples why their code is raising warnings and the example doesn't because its hidden back in the root |
|
Yeah, IMO we should bump the MSRV in this PR. |
|
@13ros27 yes that could happen, maybe we should keep the lint in the examples. I would like to hear the opinions of more people |
…erywhere (bevyengine#10011) # Objective - Fix adding `#![allow(clippy::type_complexity)]` everywhere. like bevyengine#9796 ## Solution - Use the new [lints] table that will land in 1.74 (https://doc.rust-lang.org/nightly/cargo/reference/unstable.html#lints) - inherit lint to the workspace, crates and examples. ``` [lints] workspace = true ``` ## Changelog - Bump rust version to 1.74 - Enable lints table for the workspace ```toml [workspace.lints.clippy] type_complexity = "allow" ``` - Allow type complexity for all crates and examples ```toml [lints] workspace = true ``` --------- Co-authored-by: Martín Maita <47983254+mnmaita@users.noreply.github.com>
…erywhere (bevyengine#10011) # Objective - Fix adding `#![allow(clippy::type_complexity)]` everywhere. like bevyengine#9796 ## Solution - Use the new [lints] table that will land in 1.74 (https://doc.rust-lang.org/nightly/cargo/reference/unstable.html#lints) - inherit lint to the workspace, crates and examples. ``` [lints] workspace = true ``` ## Changelog - Bump rust version to 1.74 - Enable lints table for the workspace ```toml [workspace.lints.clippy] type_complexity = "allow" ``` - Allow type complexity for all crates and examples ```toml [lints] workspace = true ``` --------- Co-authored-by: Martín Maita <47983254+mnmaita@users.noreply.github.com>
Objective
#![allow(clippy::type_complexity)]everywhere. like Allowclippy::type_complexityin more places. #9796Solution
Changelog