-
-
Notifications
You must be signed in to change notification settings - Fork 4.5k
Miri fails when unwinding in safe code #6603
Copy link
Copy link
Closed
Labels
A-ECSEntities, components, systems, and eventsEntities, components, systems, and eventsC-BugAn unexpected or incorrect behaviorAn unexpected or incorrect behaviorD-ComplexQuite challenging from either a design or technical perspective. Ask for help!Quite challenging from either a design or technical perspective. Ask for help!P-UnsoundA bug that results in undefined compiler behaviorA bug that results in undefined compiler behavior
Milestone
Metadata
Metadata
Assignees
Labels
A-ECSEntities, components, systems, and eventsEntities, components, systems, and eventsC-BugAn unexpected or incorrect behaviorAn unexpected or incorrect behaviorD-ComplexQuite challenging from either a design or technical perspective. Ask for help!Quite challenging from either a design or technical perspective. Ask for help!P-UnsoundA bug that results in undefined compiler behaviorA bug that results in undefined compiler behavior
Bevy version
f7c8eb7
What you did
I created this test:
What were you expecting
The multiple instances of
assert_non_syncshould conflict with each other and safely cause a panic.What went wrong
The following miri failure is triggered: https://github.com/JoJoJet/bevy/actions/runs/3457086747/jobs/5770279259
Additional information
I investigated a bit further on this branch. The test seems to randomly not fail sometimes, but eventually this failure was triggered:
https://github.com/JoJoJet/bevy/actions/runs/3457314695/jobs/5770662745
Some theories from @BoxyUwU https://discord.com/channels/691052431525675048/749335865876021248/1041500126880989184.