Closed
Conversation
5006c15 to
4de5077
Compare
Author
|
@evilsocket hello, may you take a look? 👀 |
Member
|
Hi, as you can see some tests are failing with this PR. Also, why the changes to go.mod and go.sum? Not sure why the zeroconf dependency needs to be removed for this set of changes. |
f104a99 to
d5edfeb
Compare
Author
|
@evilsocket Hey, thanks for the reply. I fixed the build (last commit). As I see, |
Member
|
is there a point to all of this anyway? :D |
Author
|
inspired by https://go-review.googlesource.com/c/go/+/368254 😁 |
Member
|
that's not really an answer is it? in this very thread people seem to be confused about it too |
Author
|
It reads simpler and more intuitively, especially for new people. but you can stick with |
evilsocket
added a commit
that referenced
this pull request
Jul 12, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR replaces
interface{}withany