Skip to content

replace interface{} by any#1201

Closed
imorte wants to merge 2 commits intobettercap:masterfrom
imorte:replace_interface_by_any
Closed

replace interface{} by any#1201
imorte wants to merge 2 commits intobettercap:masterfrom
imorte:replace_interface_by_any

Conversation

@imorte
Copy link

@imorte imorte commented May 17, 2025

This PR replaces interface{} with any

@imorte imorte force-pushed the replace_interface_by_any branch 2 times, most recently from 5006c15 to 4de5077 Compare May 18, 2025 10:00
@imorte
Copy link
Author

imorte commented May 22, 2025

@evilsocket hello, may you take a look? 👀

@evilsocket
Copy link
Member

Hi, as you can see some tests are failing with this PR. Also, why the changes to go.mod and go.sum? Not sure why the zeroconf dependency needs to be removed for this set of changes.

@imorte imorte force-pushed the replace_interface_by_any branch from f104a99 to d5edfeb Compare June 2, 2025 19:55
@imorte
Copy link
Author

imorte commented Jun 2, 2025

@evilsocket Hey, thanks for the reply. I fixed the build (last commit). As I see, zeroconf package is not used, it is deleted automatically with go mod tidy:

> go mod why -m github.com/grandcat/zeroconf                                                          
# github.com/grandcat/zeroconf
(main module does not need module github.com/grandcat/zeroconf)

@evilsocket
Copy link
Member

is there a point to all of this anyway? :D

@imorte
Copy link
Author

imorte commented Jun 3, 2025

inspired by https://go-review.googlesource.com/c/go/+/368254 😁

@evilsocket
Copy link
Member

that's not really an answer is it? in this very thread people seem to be confused about it too

@imorte
Copy link
Author

imorte commented Jun 3, 2025

It reads simpler and more intuitively, especially for new people. but you can stick with interface{} if you prefer

@evilsocket evilsocket closed this Jul 12, 2025
evilsocket added a commit that referenced this pull request Jul 12, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Development

Successfully merging this pull request may close these issues.

2 participants