fix(oauth-provider): allow localhost subdomains in isLocalhost function#8286
Merged
himself65 merged 4 commits intobetter-auth:canaryfrom Mar 2, 2026
Merged
Conversation
This would allow a user to set a subdomain.localhost as a redirect uri for oauth. Currently it will not allow localhost subdomains witch are common in development
|
@sicarius97 is attempting to deploy a commit to the better-auth Team on Vercel. A member of the Team first needs to authorize it. |
@better-auth/api-key
better-auth
auth
@better-auth/core
@better-auth/drizzle-adapter
@better-auth/electron
@better-auth/expo
@better-auth/i18n
@better-auth/kysely-adapter
@better-auth/memory-adapter
@better-auth/mongo-adapter
@better-auth/oauth-provider
@better-auth/passkey
@better-auth/prisma-adapter
@better-auth/redis-storage
@better-auth/scim
@better-auth/sso
@better-auth/stripe
@better-auth/telemetry
@better-auth/test-utils
commit: |
Contributor
There was a problem hiding this comment.
Pull request overview
Expands the OAuth redirect URI URL validation to treat *.localhost hostnames as localhost, enabling common dev setups that use subdomain.localhost redirect URIs.
Changes:
- Update
isLocalhost()to allow hostnames ending with.localhostfor the HTTP-allowed localhost exception.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
| function isLocalhost(hostname: string): boolean { | ||
| return ( | ||
| hostname === "localhost" || hostname === "127.0.0.1" || hostname === "[::1]" | ||
| hostname === "localhost" || hostname === "127.0.0.1" || hostname === "[::1]" || hostname.endsWith(".localhost") |
There was a problem hiding this comment.
This change expands isLocalhost to allow *.localhost, but the existing SafeUrlSchema tests don't cover this new allowed case. Add a unit test that http://<subdomain>.localhost:<port>/... is accepted, to prevent regressions and ensure the intended behavior stays supported.
Contributor
Author
There was a problem hiding this comment.
@copilot open a new pull request to apply changes based on this feedback
ALso to fix lint error
himself65
approved these changes
Mar 2, 2026
himself65
added a commit
that referenced
this pull request
Mar 3, 2026
…on (#8286) Co-authored-by: Alex Yang <himself65@outlook.com>
5 tasks
himself65
added a commit
that referenced
this pull request
Mar 3, 2026
…on (#8286) Co-authored-by: Alex Yang <himself65@outlook.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This would allow a user to set a subdomain.localhost as a redirect uri for oauth. Currently it will not allow localhost subdomains which are common in some companies development practices. This is a very simple 1 line logic change.
Summary by cubic
Treat *.localhost as localhost in OAuth redirect URI validation so subdomain.localhost redirects (e.g., app.localhost) work in local development. Refactors isLocalhost in oauth-provider zod types for clarity; fixes lint.
Written for commit 4371c3f. Summary will update on new commits.