Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub.
1 Skipped Deployment
|
@better-auth/api-key
better-auth
auth
@better-auth/core
@better-auth/drizzle-adapter
@better-auth/electron
@better-auth/expo
@better-auth/i18n
@better-auth/kysely-adapter
@better-auth/memory-adapter
@better-auth/mongo-adapter
@better-auth/oauth-provider
@better-auth/passkey
@better-auth/prisma-adapter
@better-auth/redis-storage
@better-auth/scim
@better-auth/sso
@better-auth/stripe
@better-auth/telemetry
@better-auth/test-utils
commit: |
There was a problem hiding this comment.
Pull request overview
This PR updates the Expo integration package’s build/packaging settings to avoid bundler-generated require shims, and updates the Expo demo app’s pnpm/Babel dependencies to match the new setup.
Changes:
- Set
platform: "neutral"inpackages/expotsdown config. - Switched
@better-auth/expopublished entrypoints/types from*.mjs/*.d.mtsto*.js/*.d.ts. - Updated the Expo demo to include
babel-preset-expoand pnpm build settings.
Reviewed changes
Copilot reviewed 4 out of 5 changed files in this pull request and generated 2 comments.
Show a summary per file
| File | Description |
|---|---|
| packages/expo/tsdown.config.ts | Sets neutral platform targeting for the Expo build. |
| packages/expo/package.json | Updates published entrypoints and type declaration paths/extensions. |
| demo/expo/pnpm-workspace.yaml | Adds pnpm build allowlist for better-sqlite3. |
| demo/expo/pnpm-lock.yaml | Locks babel-preset-expo addition. |
| demo/expo/package.json | Adds babel-preset-expo to support the demo’s Babel preset configuration. |
Files not reviewed (1)
- demo/expo/pnpm-lock.yaml: Language not supported
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
| "main": "./dist/index.js", | ||
| "module": "./dist/index.js", | ||
| "types": "./dist/index.d.ts", |
There was a problem hiding this comment.
main/module/types were switched to ./dist/*.js + ./dist/*.d.ts, but the build config still uses format: ["esm"] with otherwise-default tsdown settings (same as other packages that publish *.mjs + *.d.mts). Unless tsdown is also configured to change output extensions for this package, these entrypoints will point at files that aren’t emitted and the published package (and the demo’s link:) will break. Consider either keeping the *.mjs/*.d.mts paths, or explicitly configuring tsdown to emit *.js/*.d.ts for ESM output and declarations so the artifacts match the manifest.
| ], | ||
| platform: "neutral", | ||
| sourcemap: true, |
There was a problem hiding this comment.
Setting platform: "neutral" makes sense for Expo/Metro, but it doesn’t (by itself) explain the package.json switch from *.mjs/*.d.mts to *.js/*.d.ts. If the goal is to change emitted extensions, consider adding explicit tsdown options to control JS and d.ts output extensions so the build artifacts stay aligned with the package entrypoints.
No description provided.