fix #153 (JDK 21+ compatibility) by xzel23 · Pull Request #154 · beryx/badass-runtime-plugin

xzel23 · 2024-07-19T10:34:02Z

This PR fixes #153:

update ASM to 9.7 (already "knows" about Java 23 and will probably work with that version once it's released)
update Gradle wrapper to 8.9 (I still can compile with JDK 11, so I hope that's fine)
update all other dependencies to the latest versions (except the log4j version in the samples; and not requiring groovy 4)

This reverts commit ff23253.

PerryCameron · 2024-10-10T19:11:35Z

Ah this is why it wasn't working with 21. Why no merge yet after 3 months?

xzel23 · 2024-10-11T03:30:28Z

@PerryCameron I think the original maintainer, @siordache, simply does not have time to regularly update the project anymore. He asked for co-maintainers a while ago and someone stepped up, but it seems that person also has abandoned the project.

I currently have a patched version of the plugin installed locally that fixes this and an issue with kotlin build files and am thinking of forking this and publishing an updated version to plugin central (and of course continue to stream any patches upstream in case this repo gets active again).

I didn't step up as a co-maintainer back then because this project is mainly Groovy and I am really a noob in that language, but maybe I should have. In the meantime, I have volunteered to become a co-maintainer, but @siordache did not reply yet.

danielpeintner · 2024-10-16T12:06:31Z

I currently have a patched version of the plugin installed locally that fixes this and an issue with kotlin build files and am thinking of forking this and publishing an updated version to plugin central (and of course continue to stream any patches upstream in case this repo gets active again).

That sounds very promising 👍, Thanks!
Did you do so already?

xzel23 · 2024-10-18T08:27:06Z

Thank you! Not yet. It's on my list. I will post here when it's done.

xzel23 · 2024-10-19T09:19:30Z

@danielpeintner I have released a patched version of the plugin to plugin central. To use it, change the plugin id in your gradle build script fom org.beryx.runtime to com.dua3.gradle.runtime and if you also need the plugin version, I bumped it from 1.13.1 to 1.13.1-patch-1. I ha ve tested it with my own JDK 21 project, but JDK 23 should probably work too.

Please report back if something doesn't work.

And if it's of interest to anyone, I have done the same for the sister-plugin Badass-Jlink-Plugin.

Sources for my patched version of the plugin: https://github.com/xzel23/badass-runtime-plugin
Sources for the JLink plugin: https://github.com/xzel23/badass-jlink-plugin

danielpeintner · 2024-10-21T08:58:27Z

Please report back if something doesn't work.

Thank you a lot! It worked nicely 👍.
FYI: I am using JDK21.

Updates the runtime plugin to a fork with support for java 21, instead of the upstream https://github.com/beryx/badass-runtime-plugin. See beryx/badass-runtime-plugin#154 for more details. Also changed the java version back to 21.

* add runtime plugin for generating stand-alone images * add JReleaser configuration for github release and runtimes * Use runtime plugin fork Updates the runtime plugin to a fork with support for java 21, instead of the upstream https://github.com/beryx/badass-runtime-plugin. See beryx/badass-runtime-plugin#154 for more details. Also changed the java version back to 21. * Remove deploy github workflow We had a github workflow that would run on a tag push, creating a new release and uploading a zip of the language server. Jreleaser should take care of all that now, so the workflow is unnecessary. * Add changelog to github release notes So we don't have to manually add the release notes to the github release after it is published. I added a custom task to read in the full changelog, and parse out the entry for the latest version. The result is written out to a resources file that I pointed the github release config to. The jreleaser docs don't seem to be 100% clear on whether the changelog is actually what ends up in the release notes, but it would make sense to me, and the text in https://jreleaser.org/guide/latest/reference/release/github.html#_release_notes suggests it. --------- Co-authored-by: Miles Ziemer <mziemer@amazon.com>

DJViking · 2025-09-05T07:13:59Z

I got co-maintainer status on this project from @siordache some years ago, but I have been too busy with other projects and have not worked with JavaFX in years. If anyone else want to step up and help maintain this plugin that would be great, but I think only @siordache have access to add co-maintainers.

I will take a look at this PR. If I still have access as maintainer, I will merge this fix.

DJViking · 2025-09-05T07:18:38Z

 ext.badassRuntimePluginTag = Boolean.valueOf(badassRuntimePluginReleaseBuild) ? "v$ext.badassRuntimePluginVersion" : 'master'

-group = 'org.beryx'
+group = 'com.dua3.gradle'


If this is to be merged, then it would need to change back the original namespace org.beryx.

Also remove all mention of the fork, and changes to groupId and description.

I think what we want here is only the first commit in this PR.

xzel23 · 2025-09-11T10:55:00Z

I got co-maintainer status on this project from @siordache some years ago, but I have been too busy with other projects and have not worked with JavaFX in years. If anyone else want to step up and help maintain this plugin that would be great, but I think only @siordache have access to add co-maintainers.

Hi @DJViking, sorry, I have been really busy (like always), but I think I could step in here and do some maintenance work on this plugin. I do the same for its sibling, i.e., the jlink plugin by the same author.

Hi @siordache, I think I could also help out a bit with this plugin. If you are okay with this, I volunteer to become a co-maintainer.

masterflitzer · 2025-09-11T16:37:38Z

@xzel23 could you please remove the last 3 commits from this pr so it can be merged?

siordache · 2025-09-11T19:30:56Z

Hi @xzel23 , sorry for overlooking your previous request. I have now sent you an invitation to become a co-maintainer.

xzel23 · 2025-09-12T05:27:52Z

Thank you @siordache. I think I'll have some time on the weekend to make the plugin Java 25 ready (and hopefully Gradle 9).

xzel23 · 2025-09-12T05:29:25Z

@masterflitzer I'll look into this on the weekend. I think the current PR might be somewhat outdated.

masterflitzer · 2025-09-12T08:17:59Z

for gradle 9 there is #156, but jdk 25 would be amazing, thanks :)

xzel23 · 2025-09-27T05:30:20Z

This PR is obsolete, I am preparing a Java 25 compatible release.

update Gradle wrapper to 8.9, update dependency versions

bf916ee

xzel23 mentioned this pull request Jul 19, 2024

upgrade asm version #152

Closed

xzel23 added 2 commits July 20, 2024 22:48

add description to README.md

ff23253

Revert "add description to README.md"

ff5f2f5

This reverts commit ff23253.

publish plugin as version 1.13.1-patch-1 with ID com.dua3.gradle.runtime

4ce0b1e

DJViking reviewed Sep 5, 2025

View reviewed changes

xzel23 closed this Sep 27, 2025

Conversation

xzel23 commented Jul 19, 2024

Uh oh!

PerryCameron commented Oct 10, 2024

Uh oh!

xzel23 commented Oct 11, 2024

Uh oh!

danielpeintner commented Oct 16, 2024

Uh oh!

xzel23 commented Oct 18, 2024

Uh oh!

xzel23 commented Oct 19, 2024

Uh oh!

danielpeintner commented Oct 21, 2024

Uh oh!

DJViking commented Sep 5, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

DJViking Sep 5, 2025

Choose a reason for hiding this comment

Uh oh!

DJViking Sep 5, 2025

Choose a reason for hiding this comment

Uh oh!

DJViking Sep 5, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

xzel23 commented Sep 11, 2025

Uh oh!

masterflitzer commented Sep 11, 2025

Uh oh!

siordache commented Sep 11, 2025

Uh oh!

xzel23 commented Sep 12, 2025

Uh oh!

xzel23 commented Sep 12, 2025

Uh oh!

masterflitzer commented Sep 12, 2025

Uh oh!

xzel23 commented Sep 27, 2025

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

6 participants

DJViking commented Sep 5, 2025 •

edited

Loading

DJViking Sep 5, 2025 •

edited

Loading