add DefaultToAccentToggleButton#62
Merged
benruehl merged 2 commits intobenruehl:masterfrom Feb 23, 2020
Merged
Conversation
Contributor
Author
|
The style from #59 could be modified and used as a |
Owner
|
This is an update to the previous PR #59 |
benruehl
approved these changes
Feb 23, 2020
Owner
benruehl
left a comment
There was a problem hiding this comment.
Looks good to me now. Thanks for contributing!
I'm not sure about the shadow as well. I think it is ok to leave it but you can also remove it later in case you want to withdraw your decision.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I modified the button according to your comments - should now behave like a normal toggle button until checked.
Also I decided to not modify the control template - thus now the shadow host is included. (I am currently on the verge on whether it looks better with or without it)