Add AccentToggleButton#59
Conversation
|
This looks much better now, thanks. Meanwhile I was able to look at the changes directly in the demo app. There are a few things I noticed here. Minor issues:
Style name: In addition, I am struggling with the style's name. When reading the name As I understood you, it is not your intention to create a complete accent version of the ToggleButton. But instead you aimed at a better visible checked state only. That's totally fine. But I think this intention should be embodied by the name. Also to have the name "AccentToggleButton" left for the complete accented version in case it will be implemented in the future. I'd like to suggest the name |
I think we both had different visions for the accented version. - This is also why I did not add the toggle button to the layering demo. (No layering support on this version) That said I will go ahead and re-design it if I find the time. |
|
I will open another pr for this because its easier for me |
As you have already guessed correctly the previous pull request had formatting from code maid applied to it - this time around it should be much easier to spot the changed made.
I just re-forked and applied the changes again.