Rename module.runModuleSetters to just module.runSetters.#160
Merged
Conversation
The redundancy of this method name has always bothered me, so I figured I should deal with it at the same time as the module.importSync => module.watch changeover, since the risks are essentially the same. Like module.importSync, module.runModuleSetters is still defined in lib/runtime.js, but it will likely be deprecated and removed in a future version of Reify.
Contributor
|
Nice! |
benjamn
added a commit
to benjamn/install
that referenced
this pull request
May 9, 2017
taylorzane
pushed a commit
to taylorzane/reify
that referenced
this pull request
Feb 26, 2019
The redundancy of this method name has always bothered me, so I figured I should deal with it at the same time as the module.importSync => module.watch changeover, since the risks are essentially the same. Like module.importSync, module.runModuleSetters is still defined in lib/runtime.js, but it will likely be deprecated and removed in a future version of Reify.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The redundancy of this method name has always bothered me, so I figured I should deal with it at the same time as the
module.importSync→module.watchchangeover (#159), since the risks are essentially the same.Like
module.importSync,module.runModuleSettersis still defined inlib/runtime.js, but it will likely be deprecated and removed in a future version of Reify.