Revert "Introduce optional sequential_output/2 callback" #415
+0
−23
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This reverts commit dfa6987. It turned out that the parallel processing wasn't the issue with memory consumption we faced but instead copying data to processes. See: * #408 * #414 * https://pragtob.wordpress.com/2023/12/18/careful-what-data-you-send-or-how-to-tank-your-performance-with-task-async/
PragTob
added a commit
to bencheeorg/benchee_html
that referenced
this pull request
Dec 19, 2023
Turned out, that really wasn't our biggest problem - it worked by accident as it was used as a "function formatter" and hence did not launch in its own separate process and hence did not cause the memory copying problem. See: bencheeorg/benchee#415
PragTob
added a commit
that referenced
this pull request
Dec 19, 2023
So #415 is failing and it shouldn't, see: https://github.com/bencheeorg/benchee/actions/runs/7259274594/job/19776364305?pr=415 Error is weird/missing cache or something? > :dialyzer.run error: File not found: /opt/hostedtoolcache/otp/ubuntu-20.04/OTP-24.3.4.14/x64/lib/dialyzer-4.4.4.1/ebin/erl_bif_types.beam See if it's also happening here!
PragTob
added a commit
to bencheeorg/benchee_html
that referenced
this pull request
Dec 19, 2023
Turned out, that really wasn't our biggest problem - it worked by accident as it was used as a "function formatter" and hence did not launch in its own separate process and hence did not cause the memory copying problem. See: bencheeorg/benchee#415
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This reverts commit dfa6987.
It turned out that the parallel processing wasn't the issue with memory consumption we faced but instead copying data to processes.
See:
BenchmarkConfigto selectively use config in benchmark #414