Fixed checked button double right border in control group#1723
Conversation
Member
There was a problem hiding this comment.
sorry, we don't have code style checks for .styl :-/ could you move { to next line, plz?
Member
Member
|
В примере с bem.info всё хорошо: https://ru.bem.info/__example/bem-components/v2.3.0/desktop.examples/control-group/SIDLOhtJXNjeWe8RRuaqlvxv5KY/SIDLOhtJXNjeWe8RRuaqlvxv5KY.html |
Contributor
Author
|
В примере всё хорошо, потому что там |
Contributor
Author
|
Что-то я загоняюсь, в чекбоксе тоже кнопки, но в чём разница не пойму. |
Contributor
Author
|
Нашёл соответствующее правило, добавил новое для общего случая. PR обновлён. |
Member
|
lgtm |
Member
|
Fixes #1696 |
Member
|
🔥 |
tadatuta
added a commit
that referenced
this pull request
Nov 19, 2015
Fixed checked button double right border in control group
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Checked button in a control group has double right border due to
right: 1pxin button_theme_islands.styl#L337. The rule seems to be excessive, so this PR removes it.