Use alternative library to parse csharpier- and git-ignore files#1591
Merged
belav merged 3 commits intobelav:mainfrom Apr 27, 2025
Merged
Use alternative library to parse csharpier- and git-ignore files#1591belav merged 3 commits intobelav:mainfrom
belav merged 3 commits intobelav:mainfrom
Conversation
e3b2566 to
60304fe
Compare
… straightforward fix (belav#1589)" This reverts commit e5d8f01.
60304fe to
f3e2979
Compare
belav
requested changes
Apr 27, 2025
Owner
belav
left a comment
There was a problem hiding this comment.
Thanks for doing this work!
My quick performance test still showed times that aren't nearly as good as as 0.28.0 on my work repo, but I think there was something else that changed prior to 1.0.0.
I'm okay with the ignore files being case sensitive.
There are a couple of build failures around warnings + formatting, and one minor comment I have. Then this will be good to merge.
92b5b3e to
9c383d5
Compare
9c383d5 to
c37a94d
Compare
Author
|
@belav Should be done. I have some trouble getting your coding style rules to run in Rider so I rely on the CI builds to check formatting. It does look fine on my fork and I hope it does as well on the checks here. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Using gitignore parser library instead of building ignore rules ourselves improves csharpier performance drastically even with large repositories and a lot of ignore rules.
This would introduce a potentially breaking change as the rules are now case-sensitive by default since git is as well.
I had to remove one unit test as we would not parse the ignore-files ourselves anymore as well as alter one which was testing case-insensitive paths.