Added loads of test candidates and updated discord webhook regex#216
Merged
bee-san merged 4 commits intobee-san:mainfrom Oct 22, 2021
Merged
Added loads of test candidates and updated discord webhook regex#216bee-san merged 4 commits intobee-san:mainfrom
bee-san merged 4 commits intobee-san:mainfrom
Conversation
Added loads of test candidates and updated discord webhook regex as per bee-san#208
1 task
Owner
|
your tests fail :( |
Contributor
Author
yeah..that's odd |
lmao json formatting goes brr
Contributor
Author
lmao im dumb 😆 , forgot to remove the extra |
Codecov Report
@@ Coverage Diff @@
## main #216 +/- ##
=======================================
Coverage 92.52% 92.52%
=======================================
Files 14 14
Lines 1204 1204
=======================================
Hits 1114 1114
Misses 90 90 Continue to review full report at Codecov.
|
1 task
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Prerequisites
Why do we need this pull request?
Better webhook url regex, to allow other subdomains such as ptb & canary which are actively used as well as allowing for the detection of webhooks using the old domain discordapp.com and allowing for the matching of webhook urls that include the api version after the api path and more distinct expressions for webhook tokens and webhook ids, also allowing for webhook urls that have the scheme of http
What GitHub issues does this fix?
Expands upon changes made in #173 and continuation of #208 due to merge conflicts with new regex test system introduced via #202
Copy / paste of output
Couldn't get the script to work so I could not test the changes to the regex i've made with the regex however I have tested it on its own in python 3.10 as well as using https://pythex.org