⚠️ Please install the to ensure uploads and comments are reliably processed by Codecov.

Codecov Report

❌ Patch coverage is 83.33333% with 5 lines in your changes missing coverage. Please review.
✅ Project coverage is 92.32%. Comparing base (2589780) to head (c7970e4).
⚠️ Report is 102 commits behind head on main.

@@            Coverage Diff             @@
##             main     #202      +/-   ##
==========================================
- Coverage   94.50%   92.32%   -2.19%     
==========================================
  Files          14       14              
  Lines        1729     1198     -531     
==========================================
- Hits         1634     1106     -528     
+ Misses         95       92       -3     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Can you change "Matches" to "Examples"?

Yeah, I'm planing on also adding some strings that should not be matched. Does something like this sound alright?

{
  "Name": "Email Address",
  ...
  "Examples": {
    "Valid": ["firstname+lastname@example.com"],
    "Invalid": ["email@example@example.com"]
  }
}

def test_email4():
    res = r.check(["email@example@example.com"])
    assert "Email Address" not in res

Can you change "Matches" to "Examples"?

Yeah, I'm planing on also adding some strings that should not be matched. Does something like this sound alright?

{

  "Name": "Email Address",

  ...

  "Examples": {

    "Valid": ["firstname+lastname@example.com"],

    "Invalid": ["email@example@example.com"]

  }

}

def test_email4():

    res = r.check(["email@example@example.com"])

    assert "Email Address" not in res

Amazing

This is great!! Makes it way easier for people to test their code, and it allows people in the future to see examples of things :D

happy to merge this, 1 question -- why is code coverage down? 🤔 other than that, it looks good to me :D !!! 🥳

This is great!! Makes it way easier for people to test their code, and it allows people in the future to see examples of things :D

happy to merge this, 1 question -- why is code coverage down? thinking other than that, it looks good to me :D !!! partying_face

Thanks!

Code coverage is down due to amount of lines of code removed, as pytest is practically just rerunning the function for each match. JSON does not contribute to coverage either. I will be checking that there is the same amount of test cases before and after, that way I know I haven't left anything out accidentally.

Please squash!

Can you change the codecov stuff slightly so it passes CI? :)