Changed layout of accordions.#2
Merged
beat merged 1 commit intomysqlprofilingfrom Jun 15, 2013
unknown repository
Merged
Conversation
Fixed some css issues. Changed classname syntax. Added language strings. Improved method of determining what queries should be marked green/red/yellow. And more...
Author
|
You might want to play around with the $timeScore if structure, which determine which queries are marked green/yellow/red. |
There was a problem hiding this comment.
It looks like that there is one space instead of two between the param type and its name.
Could it be that you're using PhpStorm ? This is oh so annoying....
Owner
|
@nonumber : Great stuff! Well done, and many thanks of doing all the cleanups. |
beat
added a commit
that referenced
this pull request
Jun 15, 2013
Merging Changed layout of accordions from @nonumber with many thanks ! Well done! Actually if you want, you could apply the same kind of bargraphs to the PHP+Memory+Total SQL queries time total in there in the profiling section. That way it would be immediately visible if a badly written small module kills a site's performance. Even more, with correlating the PHP profiling utime-timestamps with the SQL queries ones, the PHP section could be spitting out really useful information. ;)
beat
pushed a commit
that referenced
this pull request
Feb 17, 2016
Allow users to accept & configure stats sending
beat
pushed a commit
that referenced
this pull request
Feb 17, 2016
Add an implementation of JCryptCipher using the Crypto class
beat
added a commit
that referenced
this pull request
Jan 22, 2022
Fixes `Deprecated: mysqli_real_escape_string(): Passing null to parameter #2 ($string) of type string is deprecated in libraries/joomla/database/driver/mysqli.php on line 254`
beat
added a commit
that referenced
this pull request
Jan 23, 2022
…fixes Deprecated tinymce.php on line 603) Fixes `Deprecated: htmlentities(): Passing null to parameter #2 ($flags) of type int is deprecated in plugins/editors/tinymce/tinymce.php on line 603` Joomla 3.10 version of Joomla 4.0 joomla#36761
beat
added a commit
that referenced
this pull request
Jan 23, 2022
…6787) * [3.10] [PHP 8.1] Mysqli database driver escapt function fix Fixes `Deprecated: mysqli_real_escape_string(): Passing null to parameter #2 ($string) of type string is deprecated in libraries/joomla/database/driver/mysqli.php on line 254` * Fix also the other db drivers Co-authored-by: Richard Fath <richard67@users.noreply.github.com>
HLeithner
pushed a commit
that referenced
this pull request
Jun 27, 2022
…ler-sql-improvements-mod-1 [CMS PR 36506] Branch update and merge conflicts resolution
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixed some css issues.
Changed classname syntax.
Added language strings.
Improved method of determining what queries should be marked green/red/yellow.
Added back the 0.3% min width to bar parts.
And more...