Closed
Conversation
Contributor
|
So I was thinking of an alternative -- instead of trying to merge in the configuration's default shell env, what if we used |
Member
Author
|
Use which |
Contributor
|
|
Member
Author
|
ah, I think piping that through would probably be a bit more difficult than this. I'm not sure we want to compete with bazel's logic for this |
Through the investigation of bazelbuild/bazel#12049 one of the things I discovered was that when using `actions.run` there are 2 options for environment variables. `use_default_shell_env = True` is recommended, but cannot be used if you want to also pass `env` to the actions. To support Xcode version selection we have to pass `env` with those variables. Without the default shell env, we only get the environment variables defined in the crosstool, but not those passed with `--action_env`. This now adds variables passed as `--action_env=FOO=BAR`, but not those passed as `--action_env=FOO` (where the value is supposed to pass through). This is useful to ensure a few things: 1. The default PATH things are executed with includes /usr/local/bin. This can result in pollution of binaries from homebrew. Previously there was no way to limit this 2. This should be a good replacement for using custom Swift toolchains. Currently those environment variables only apply to some actions (excluding those from bazel) using `--action_env=TOOLCHAINS=foo` should work better than the current solution (this change can be made as a followup)
d2c1579 to
c5b0e71
Compare
Collaborator
|
FYI: I've been using this with |
brentleyjones
approved these changes
Jun 4, 2021
Member
Author
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Through the investigation of
bazelbuild/bazel#12049 one of the things I
discovered was that when using
actions.runthere are 2 options forenvironment variables.
use_default_shell_env = Trueis recommended,but cannot be used if you want to also pass
envto the actions. Tosupport Xcode version selection we have to pass
envwith thosevariables. Without the default shell env, we only get the environment
variables defined in the crosstool, but not those passed with
--action_env. This now adds variables passed as--action_env=FOO=BAR, but not those passed as--action_env=FOO(where the value is supposed to pass through).
This is useful to ensure a few things:
This can result in pollution of binaries from homebrew. Previously
there was no way to limit this
Currently those environment variables only apply to some actions
(excluding those from bazel) using
--action_env=TOOLCHAINS=fooshould work better than the current solution (this change can be made
as a followup)