Enable use_default_shell_env everywhere#1114
Merged
Conversation
Now that bazel 7.x has https://bazel.build/reference/command-line-reference#flag--incompatible_merge_fixed_and_default_shell_env enabled by default, we can set `use_default_shell_env = True` moving forward. This makes actions respect `--action_env=FOO` which can be useful for things like `TOOLCHAINS`, `ZERO_AR_DATE`, `TMPDIR`, etc. Previously these were ignored.
brentleyjones
approved these changes
Sep 19, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Now that bazel 7.x has
https://bazel.build/reference/command-line-reference#flag--incompatible_merge_fixed_and_default_shell_env
enabled by default, we can set
use_default_shell_env = Truemovingforward. This makes actions respect
--action_env=FOOwhich can beuseful for things like
TOOLCHAINS,ZERO_AR_DATE,TMPDIR, etc.Previously these were ignored.