declare CARGO_CFG_(WINDOWS|UNIX) in build scripts#1025
Merged
UebelAndre merged 2 commits intobazelbuild:mainfrom Nov 19, 2021
Merged
declare CARGO_CFG_(WINDOWS|UNIX) in build scripts#1025UebelAndre merged 2 commits intobazelbuild:mainfrom
UebelAndre merged 2 commits intobazelbuild:mainfrom
Conversation
UebelAndre
requested changes
Nov 18, 2021
Collaborator
UebelAndre
left a comment
There was a problem hiding this comment.
One question probably for my own sake. Also, could you add a test that asserts CARGO_CFG_(WINDOWS|UNIX) is set in the expected cases?
UebelAndre
requested changes
Nov 18, 2021
These variables are documented as being available: https://doc.rust-lang.org/cargo/reference/environment-variables.html#environment-variables-cargo-sets-for-build-scripts The latest rusqlite depends on CARGO_CFG_WINDOWS to be defined in order to link correctly: rusqlite/rusqlite#961
73664c4 to
63e9f4d
Compare
UebelAndre
approved these changes
Nov 19, 2021
Collaborator
UebelAndre
left a comment
There was a problem hiding this comment.
Awesome work! Thanks for putting this together 😄
ddeville
pushed a commit
to ddeville/rules_rust
that referenced
this pull request
Nov 22, 2021
* declare CARGO_CFG_(WINDOWS|UNIX) in build scripts These variables are documented as being available: https://doc.rust-lang.org/cargo/reference/environment-variables.html#environment-variables-cargo-sets-for-build-scripts The latest rusqlite depends on CARGO_CFG_WINDOWS to be defined in order to link correctly: rusqlite/rusqlite#961 * add a test for rustc cfg parsing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
These variables are documented as being available:
https://doc.rust-lang.org/cargo/reference/environment-variables.html#environment-variables-cargo-sets-for-build-scripts
The latest rusqlite depends on CARGO_CFG_WINDOWS to be defined
in order to link correctly: rusqlite/rusqlite#961