Preserve mtimes from input tar files in TarFileWriter output tars#155
Merged
aiuto merged 3 commits intobazelbuild:masterfrom Apr 21, 2020
Merged
Preserve mtimes from input tar files in TarFileWriter output tars#155aiuto merged 3 commits intobazelbuild:masterfrom
aiuto merged 3 commits intobazelbuild:masterfrom
Conversation
Collaborator
Author
|
@aiuto please let me know if I missed something about your recommendation - my understanding is that removing this line gives us the behavior you were describing, where output tars always respect the mtimes of input tars. |
Collaborator
|
So this is roughly https://github.com/bazelbuild/bazel/pull/11028/files |
aiuto
requested changes
Apr 16, 2020
Collaborator
aiuto
left a comment
There was a problem hiding this comment.
Thanks for your patience while I was backlogged.
Collaborator
Author
|
No problem! This PR should be up to date with that requested change now. |
aiuto
requested changes
Apr 18, 2020
aiuto
approved these changes
Apr 21, 2020
dannysullivan
added a commit
to dannysullivan/rules_docker
that referenced
this pull request
May 6, 2020
This fixes a mistake in bazelbuild/rules_pkg#155 - I missed one instance of hardcoding the value False. This PR also adds a test of this configuration option.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This tool should not need to override mtimes for files contained in tar files that are added to the output of TarFileWriter, since these files are either constructed by other parts of the build process (in which case we can rely on the caching and reproducibility of those steps) or they are constructed outside of the bazel system, in which case we shouldn't need to alter them.
See discussion on this issue for more information.
Fixes #149