Enable linking of imported Swift static frameworks#566
Merged
swiple-rules-gardener merged 7 commits intobazelbuild:masterfrom Sep 6, 2019
Conversation
Contributor
Author
|
@sergiocampama if this looks about right I will add some tests. |
keith
reviewed
Aug 27, 2019
keith
reviewed
Sep 4, 2019
Contributor
Author
|
Updated to add tests. |
Contributor
Author
|
The test failures look unrelated. |
54d8653 to
fbac918
Compare
sergiocampama
suggested changes
Sep 6, 2019
Contributor
sergiocampama
left a comment
There was a problem hiding this comment.
small nit but looks good, thanks for the tests!
Contributor
Author
|
Fixed the nit. Thanks for reviewing. |
kastiglione
commented
Sep 6, 2019
Contributor
|
I'm a bit worried about that generated header without the disclaimer at the top, but I understand why it is that way. if our tools complain, I'll fix it internally |
sergiocampama
approved these changes
Sep 6, 2019
Contributor
Author
|
If necessary I can change the script to have a disclaimer. |
Contributor
|
no need, we figured it out :) |
swiple-rules-gardener
added a commit
that referenced
this pull request
Sep 6, 2019
…d-swift-static-frameworks PiperOrigin-RevId: 267639766
rebello95
added a commit
to envoyproxy/envoy-mobile
that referenced
this pull request
Sep 6, 2019
We can now remove the hack for building the Objective-C demo now that bazelbuild/rules_apple#566 has merged (thanks @kastiglione!). Signed-off-by: Michael Rebello <me@michaelrebello.com>
rebello95
added a commit
to envoyproxy/envoy-mobile
that referenced
this pull request
Sep 6, 2019
We can now remove the hack for building the Objective-C demo now that bazelbuild/rules_apple#566 has merged (thanks @kastiglione!). Signed-off-by: Michael Rebello <me@michaelrebello.com>
Contributor
Author
|
This caused a problem in cases where a Swift implemented |
jpsim
pushed a commit
to envoyproxy/envoy
that referenced
this pull request
Nov 28, 2022
We can now remove the hack for building the Objective-C demo now that bazelbuild/rules_apple#566 has merged (thanks @kastiglione!). Signed-off-by: Michael Rebello <me@michaelrebello.com> Signed-off-by: JP Simard <jp@jpsim.com>
jpsim
pushed a commit
to envoyproxy/envoy
that referenced
this pull request
Nov 29, 2022
We can now remove the hack for building the Objective-C demo now that bazelbuild/rules_apple#566 has merged (thanks @kastiglione!). Signed-off-by: Michael Rebello <me@michaelrebello.com> Signed-off-by: JP Simard <jp@jpsim.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This supports the case where a non-Swift target, such as an
ios_application, has aapple_static_framework_importdependency whose binary depends on the Swift runtime.Resolves #557.