Conversation
|
Lyft integration job started: https://buildkite.com/lyft/rules-apple/builds/527 (must be Lyft employee to view) |
483bafa to
e41a071
Compare
This change rewrites the `apple_static_xcframework` macro to a rule using the experimental static library linking API (`link_multi_arch_static_library`). - Refactor `apple_static_library` underlying macro targets to use `link_multi_arch_static_library` API instead. - Replace split transition to `xcframework_transition` since we no longer rely on `apple_static_library` default `multi_arch_split`. - Update `apple_static_xcframework` tests to remove the `.apple_static_library` "suffix", and file path names (due to the change of underlying transition). PiperOrigin-RevId: 435666883
|
Lyft integration job started: https://buildkite.com/lyft/rules-apple/builds/528 (must be Lyft employee to view) |
This change rewrites the `apple_static_xcframework` macro to a rule using the experimental static library linking API (`link_multi_arch_static_library`). - Refactor `apple_static_library` underlying macro targets to use `link_multi_arch_static_library` API instead. - Replace split transition to `xcframework_transition` since we no longer rely on `apple_static_library` default `multi_arch_split`. - Update `apple_static_xcframework` tests to remove the `.apple_static_library` "suffix", and file path names (due to the change of underlying transition). PiperOrigin-RevId: 435666883 (cherry picked from commit 0ab315c)
e41a071 to
c9b5523
Compare
|
Lyft integration job started: https://buildkite.com/lyft/rules-apple/builds/529 (must be Lyft employee to view) |
This change replaces current bundling managed by xcodebuild, to use rules_apple partials, and custom XCFrameworks bundling. PiperOrigin-RevId: 436273478 (cherry picked from commit adf0a39)
This change replaces current bundling managed by xcodebuild, to use rules_apple partials, and custom XCFrameworks bundling. PiperOrigin-RevId: 436273478
|
Lyft integration job started: https://buildkite.com/lyft/rules-apple/builds/532 (must be Lyft employee to view) |
Replaces public_hdrs bundling to use the framework_header_modulemap_partial to generate modulemaps and umbrella headers for each XCFramework library. PiperOrigin-RevId: 440923000 (cherry picked from commit de6a519)
Replaces public_hdrs bundling to use the framework_header_modulemap_partial to generate modulemaps and umbrella headers for each XCFramework library. PiperOrigin-RevId: 440923000
|
Lyft integration job started: https://buildkite.com/lyft/rules-apple/builds/534 (must be Lyft employee to view) |
This change adds support for Swift based static XCFrameworks, in a similar fashion as dynamic XCFrameworks does today using the `swift_framework_partial`, and custom bundling for `.swiftmodule` files under a library identifier directory instead of `Modules/` directory. PiperOrigin-RevId: 441610792 (cherry picked from commit 1b19374)
This change adds support for Swift based static XCFrameworks, in a similar fashion as dynamic XCFrameworks does today using the `swift_framework_partial`, and custom bundling for `.swiftmodule` files under a library identifier directory instead of `Modules/` directory. PiperOrigin-RevId: 441610792
|
Lyft integration job started: https://buildkite.com/lyft/rules-apple/builds/537 (must be Lyft employee to view) |
PiperOrigin-RevId: 441872601 (cherry picked from commit d873646)
This change adds additional tests to `apple_static_xcframework` rule,\ to verify static libraries builds for simulator/device using Mach-O load\ commands. Currently Mach-O files include either `LC_BUILD_VERSION` or\ `LC_VERSION_MIN_IPHONEOS` depending on the target environment and target\ minimum iOS version. PiperOrigin-RevId: 443200094 (cherry picked from commit 702370f)
This change adds additional tests to `apple_static_xcframework` rule,\ to verify static libraries builds for simulator/device using Mach-O load\ commands. Currently Mach-O files include either `LC_BUILD_VERSION` or\ `LC_VERSION_MIN_IPHONEOS` depending on the target environment and target\ minimum iOS version. PiperOrigin-RevId: 443200094
|
Lyft integration job started: https://buildkite.com/lyft/rules-apple/builds/541 (must be Lyft employee to view) |
|
Lyft integration job started: https://buildkite.com/lyft/rules-apple/builds/542 (must be Lyft employee to view) |
Update rules_apple to have xcframework improvements bazelbuild/rules_apple#1443 Signed-off-by: JP Simard <jp@jpsim.com>
46c38ae to
71b5b66
Compare
|
Lyft integration job started: https://buildkite.com/lyft/rules-apple/builds/549 (must be Lyft employee to view) |
71b5b66 to
7bbd037
Compare
|
Lyft integration job started: https://buildkite.com/lyft/rules-apple/builds/550 (must be Lyft employee to view) |
7bbd037 to
694d879
Compare
|
Lyft integration job started: https://buildkite.com/lyft/rules-apple/builds/551 (must be Lyft employee to view) |
jpsim
left a comment
There was a problem hiding this comment.
apple_static_xcframework appears to be working well in my tests here: envoyproxy/envoy-mobile#2217
|
Lyft integration job started: https://buildkite.com/lyft/rules-apple/builds/556 (must be Lyft employee to view) |
416cef7 to
bbad80c
Compare
|
Lyft integration job started: https://buildkite.com/lyft/rules-apple/builds/557 (must be Lyft employee to view) |
bbad80c to
0f66ee3
Compare
|
Lyft integration job started: https://buildkite.com/lyft/rules-apple/builds/558 (must be Lyft employee to view) |
See each commit for details. This depends on bazelbuild/bazel@8778455 in bazel, which is not in the 5.x branches