Merged
Conversation
I'm not really satisified with this PR. The number of Apple specific platforms has grown to the point where we may want to refactor them. The question I would focus on is how various toolchain matches and select clauses go.
Do we see things like:
```
foo = select({
".../os:linux": A,
".../os:windows": B,
".../os:macos": C,
".../os:watchos": C,
".../os:visionos": C,
})
```
Where C is the same for all the apple platforms?
Or, do we see real distinctions across the various per-device OSes. Or a mix of both?
And, do we see the fanout of the Apple OSes done with a select_or wrapper, so users end up seeing the simple selection of just apple, linux, or windows, but we buried complexity elsewhere?
Member
|
I think in general we see both "all apple" selects and specific OS version selects. In apple_support we provide a config_setting for "all apple" here. |
keith
approved these changes
Jul 11, 2023
Member
keith
left a comment
There was a problem hiding this comment.
I just submitted bazelbuild/bazel#18905 which is also required for this new support, it would be nice if this one could land as well
This was referenced Jul 11, 2023
keith
added a commit
to bazelbuild/apple_support
that referenced
this pull request
Jul 11, 2023
keith
added a commit
to bazelbuild/apple_support
that referenced
this pull request
Jul 11, 2023
brentleyjones
approved these changes
Jul 11, 2023
keith
added a commit
to bazelbuild/apple_support
that referenced
this pull request
Jul 14, 2023
Member
|
@aiuto friendly ping |
meteorcloudy
approved these changes
Jul 28, 2023
katre
approved these changes
Jul 28, 2023
|
Thanks @meteorcloudy @katre! |
Member
|
Thanks folks, could you also push a |
Contributor
Author
|
I'll get to that today. Have to run a short errand. |
keith
added a commit
to bazelbuild/apple_support
that referenced
this pull request
Aug 10, 2023
keith
added a commit
to bazelbuild/apple_support
that referenced
this pull request
Aug 10, 2023
keith
added a commit
to bazelbuild/apple_support
that referenced
this pull request
Aug 12, 2023
keith
added a commit
to bazelbuild/apple_support
that referenced
this pull request
Aug 12, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I'm not really satisified with this PR. The number of Apple specific platforms has grown to the point where we may want to refactor them. The question I would focus on is how various toolchain matches and select clauses go.
Do we see things like:
Where C is the same for all the apple platforms?
Or, do we see real distinctions across the various per-device OSes. Or a mix of both? And, do we see the fanout of the Apple OSes done with a select_or wrapper, so users end up seeing the simple selection of just apple, linux, or windows, but we buried complexity elsewhere?