Skip to content

Build java_tools for darwin arm64#1511

Merged
meteorcloudy merged 5 commits intobazelbuild:masterfrom
hvadehra:patch-1
Dec 13, 2022
Merged

Build java_tools for darwin arm64#1511
meteorcloudy merged 5 commits intobazelbuild:masterfrom
hvadehra:patch-1

Conversation

@hvadehra
Copy link
Copy Markdown
Member

@hvadehra hvadehra commented Dec 8, 2022

java_tools for darwin will be built as a fat universal binary after bazelbuild/bazel#16960 so it needs to use the osx toolchain.

@hvadehra hvadehra changed the title Add macos_arm64 Add macos_arm64 for java_tools Dec 8, 2022
@hvadehra hvadehra changed the title Add macos_arm64 for java_tools Build java_tools for darwin arm64 Dec 13, 2022
@hvadehra hvadehra marked this pull request as ready for review December 13, 2022 13:07
@meteorcloudy meteorcloudy merged commit da72a5b into bazelbuild:master Dec 13, 2022
@fweikert
Copy link
Copy Markdown
Member

Why did you revert to macos? It's not using the M1 workers anymore.

@meteorcloudy
Copy link
Copy Markdown
Member

My understanding is that there will be one java_tools archive for macOS, and it works both on x86 and arm64 platforms? @hvadehra Is that correct?

@hvadehra
Copy link
Copy Markdown
Member Author

Yes, we are cross-compiling to both architectures and merging into a single binary. And it doesn't matter which host we use as long as xcode version >= 12.2.

@hvadehra hvadehra deleted the patch-1 branch December 13, 2022 15:33
fmeum pushed a commit to fmeum/continuous-integration that referenced this pull request Dec 10, 2023
java_tools for darwin will be built as a fat universal binary after
bazelbuild/bazel#16960 so it needs to use the
osx toolchain.
fweikert pushed a commit to fweikert/continuous-integration that referenced this pull request Mar 27, 2025
java_tools for darwin will be built as a fat universal binary after
bazelbuild/bazel#16960 so it needs to use the
osx toolchain.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants